Skip to content

Commit

Permalink
Remove DateDeserializer, close Java GitHub issue 333 (#334)
Browse files Browse the repository at this point in the history
  • Loading branch information
jchen293 authored Sep 16, 2024
1 parent a58d4fb commit ac02505
Show file tree
Hide file tree
Showing 8 changed files with 306 additions and 374 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## Next Release

- Remove the custom DateDeserializer that contained a parsing issue. This change closes the related GitHub issue [#333](https://github.com/EasyPost/easypost-java/issues/333)

## v7.4.2 (2024-08-09)

- Fix pagination parameters for `getNextPage` in `User` service
Expand Down
5 changes: 1 addition & 4 deletions src/main/java/com/easypost/Constants.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import com.easypost.http.HashMapSerializer;
import com.easypost.model.AddressVerification;
import com.easypost.model.AddressVerificationDeserializer;
import com.easypost.model.DateDeserializer;
import com.easypost.model.Error;
import com.easypost.model.ErrorDeserializer;
import com.easypost.model.SmartrateCollection;
Expand All @@ -17,7 +16,6 @@
import com.google.gson.Gson;
import com.google.gson.GsonBuilder;

import java.util.Date;
import java.util.HashMap;
import java.util.List;

Expand Down Expand Up @@ -85,8 +83,7 @@ public abstract static class Http {
.registerTypeAdapter(Error.class, new ErrorDeserializer())
.registerTypeAdapter(AddressVerification.class, new AddressVerificationDeserializer())
.registerTypeAdapter(StatelessRate[].class, new StatelessRateDeserializer())
.registerTypeAdapter(Webhook[].class, new WebhookDeserializer())
.registerTypeAdapter(Date.class, new DateDeserializer()).create();
.registerTypeAdapter(Webhook[].class, new WebhookDeserializer()).create();
public static final Gson PRETTY_PRINT_GSON = new GsonBuilder().setPrettyPrinting().serializeNulls()
.setFieldNamingPolicy(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES).create();
}
Expand Down
78 changes: 0 additions & 78 deletions src/main/java/com/easypost/model/DateDeserializer.java

This file was deleted.

38 changes: 19 additions & 19 deletions src/test/cassettes/claim/all.json

Large diffs are not rendered by default.

168 changes: 84 additions & 84 deletions src/test/cassettes/claim/cancel.json

Large diffs are not rendered by default.

131 changes: 67 additions & 64 deletions src/test/cassettes/claim/create.json

Large diffs are not rendered by default.

83 changes: 43 additions & 40 deletions src/test/cassettes/claim/get_next_page.json

Large diffs are not rendered by default.

173 changes: 88 additions & 85 deletions src/test/cassettes/claim/retrieve.json

Large diffs are not rendered by default.

0 comments on commit ac02505

Please sign in to comment.