Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up Java build warnings #284

Merged
merged 1 commit into from
Sep 6, 2023
Merged

clean up Java build warnings #284

merged 1 commit into from
Sep 6, 2023

Conversation

jchen293
Copy link
Member

@jchen293 jchen293 commented Sep 6, 2023

Description

Clean up Java build warnings by:

  • Adding @InlineMe to the deprecated function so that when users call the method tagged with @InlineMe will be migrated to the new method. This implementation is optional but it's worth adding it.
  • Removing the printStackTrace() and throw an exception instead

More resource: https://errorprone.info/docs/inlineme

Testing

E2E ran make clean publish-dry

Screenshot 2023-09-06 at 4 19 00 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team September 6, 2023 20:20
@Justintime50
Copy link
Member

Please add a description to the summary about how this cleans up the errors. I'm not sure what the inline syntax does.

@jchen293
Copy link
Member Author

jchen293 commented Sep 6, 2023

Please add a description to the summary about how this cleans up the errors. I'm not sure what the inline syntax does.

Something optional to add, updated the description of the PR summary

@jchen293 jchen293 merged commit 1d62e88 into master Sep 6, 2023
16 checks passed
@jchen293 jchen293 deleted the fix-build-warnings branch September 6, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants