[fix] Address verification details lost during deserialization #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unit test to verify AddressVerification deserialization works properly
jchen293
reviewed
Nov 13, 2023
nwithan8
force-pushed
the
verifications
branch
from
746b5b2
to
713dbb7
Compare
jchen293
approved these changes
Nov 15, 2023
Justintime50
approved these changes
Nov 15, 2023
| assertNotNull(address.getVerifications().getZip4().getErrors()); // Should have a error due to second line | ||
| assertNotNull(address.getVerifications().getDelivery().getErrors()); | ||
|
|
||
| assertFalse(address.getVerifications().getDelivery().getErrors().isEmpty()); // should have at least one error |
There was a problem hiding this comment.
suggestion: the double negative is hard to read. We should probably be asserting that it is present instead
There was a problem hiding this comment.
IDE didn't like that we weren't using this "simplified" way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our current setup reuses the
Errorclass to represent address verification errors. However, theErrorclass has a custom deserializer that is being called during typical JSON deserialization in our library. Hard-coded logic inside that deserializer was effectively causing deserialization of the hints for address verification to fail.This PR introduces another custom deserializer, specifically for the
AddressVerificationclass that handles deserializing address verification JSON without theErrordeserializer getting in the way.Closes #288
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.