fix: webhook validation when float weight field is present (closes #467) #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
weight
field is present on a webhook (eg: tracking update), it gets converted but JS drops the decimal if.0
which often is the case. This breaks webhook validation because HMAC signatures won't match if it's altered at all. This properly puts back the.0
if necessary and missing to ensure that validation will continue to work. Tests validate that we properly compare the signaturesTesting
Pull Request Type
Please select the option(s) that are relevant to this PR.