Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Account for new UPS endpoint in carrier account create/update functions #336

Merged
merged 7 commits into from
Jul 9, 2024
Merged

feat: Account for new UPS endpoint in carrier account create/update functions #336

merged 7 commits into from
Jul 9, 2024

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Jul 3, 2024 •
edited
Loading

Description

  • Routes UpsAccount, UpsMailInnovationsAccount, and UpsSurepostAccount create/update requests to the new /ups_oauth_registrations endpoint

Testing

Adds new tests for each, updates previous custom workflow test to use FedEx instead of UPS

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team July 3, 2024 21:23
jchen293
jchen293 previously approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nwithan8
nwithan8 previously approved these changes Jul 4, 2024
View reviewed changes
@Justintime50 Justintime50 dismissed stale reviews from nwithan8 and jchen293 via 5036b2a July 8, 2024 20:27
jchen293
jchen293 reviewed Jul 8, 2024
View reviewed changes
easypost/services/carrier_account_service.py Outdated Show resolved Hide resolved
tests/test_carrier_account.py Outdated Show resolved Hide resolved
jchen293
jchen293 previously approved these changes Jul 8, 2024
View reviewed changes
nwithan8
nwithan8 previously approved these changes Jul 8, 2024
View reviewed changes
@Justintime50 Justintime50 dismissed stale reviews from nwithan8 and jchen293 via 5be741a July 9, 2024 17:24
jchen293
jchen293 reviewed Jul 9, 2024
View reviewed changes
tests/test_carrier_account.py Outdated Show resolved Hide resolved
easypost/services/base_service.py Show resolved Hide resolved
jchen293
jchen293 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, questions answered

@Justintime50 Justintime50 merged commit 02b474d into master Jul 9, 2024
8 checks passed
@Justintime50 Justintime50 deleted the ups_oauth branch July 9, 2024 19:06
@nwithan8 nwithan8 changed the title feat: add new create_ups and update_ups functions feat: Account for new UPS endpoint in carrier account create/update functions Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justintime50 @nwithan8 @jchen293