Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring calc_rssrbs.m #165

Open
BSchilperoort opened this issue May 23, 2023 · 2 comments
Open

Refactoring calc_rssrbs.m #165

BSchilperoort opened this issue May 23, 2023 · 2 comments
Labels
24 May Issues to tackle during the "Best practices in STEMMUS_SCOPE" workshop

Comments

@BSchilperoort
Copy link
Contributor

BSchilperoort commented May 23, 2023 •
edited
Loading

The file calc_rssrbs.m has two problems:

  • There is no documentation. What does this function do?
  • It uses global variables. These should be changed to input arguments and passed to the function.

Additionally, it would be good to also rename the variables/structures according to the style guide where possible.
@BSchilperoort BSchilperoort added the 24 May Issues to tackle during the "Best practices in STEMMUS_SCOPE" workshop label May 23, 2023
@EntingTang EntingTang mentioned this issue May 24, 2023
Open
7 tasks
@bobzsu
Copy link
Contributor

bobzsu commented May 24, 2023

use 'SoilProperties' instead of 'global' in
" global SaturatedMC ResidualMC fieldMC"

SaturatedMC not used.
ResidualMC = SoilProperties.ResidualMC
fieldMC = SoilProperties.ResidualMC

@bobzsu
Copy link
Contributor

bobzsu commented May 24, 2023

also add source/reference of equation, and meanings of constants 3.8, 4.1 and 4.3 (+reference, eq. no and explanation of constants)

@yijianzeng yijianzeng mentioned this issue May 24, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
24 May Issues to tackle during the "Best practices in STEMMUS_SCOPE" workshop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BSchilperoort @bobzsu