Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSM_v.0.1: Add a new function to read MODFLOW head and define the bottom of the soil layer that include that head #218

Closed
wants to merge 10 commits into from

Conversation

MostafaGomaa93
Copy link
Contributor

Description

The changes are as follows:
1- a new function "TIME_INTERPOLATION" is added. It reads MODFLOW heads and defines the bottom of the soil layer that includes that head. Currently, the output of the function is not used yet but will be used later in the next modification steps.
2- Corresponding modifications are in getModelSettings.m and define_constants.m files

I have included in the code the description of the variables I know so far, but not sure about all of them yet. The function must be checked by @Lianyu-Yu (the original author), and further checks by other members. Still a room of changes is expected after I got responses of my questions in issue 217 from @Lianyu-Yu

Checklist

  • [✓] Add a reference to related issues -> issue 217
  • [✓] @mentions of the person or team responsible for reviewing proposed changes -> @SarahAlidoost, @Lianyu-Yu, @BSchilperoort, @yijianzeng
  • [✓] This pull request has a descriptive title.
  • [✓] Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • [✓ ] Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@MostafaGomaa93 MostafaGomaa93 changed the title SSm v.0.1_ Add a new function to read MODFLOW head and define the bottom of the soil layer that include that head SSM v.0.1_ Add a new function to read MODFLOW head and define the bottom of the soil layer that include that head Jan 31, 2024
@MostafaGomaa93 MostafaGomaa93 changed the title SSM v.0.1_ Add a new function to read MODFLOW head and define the bottom of the soil layer that include that head SSM_v.0.1: Add a new function to read MODFLOW head and define the bottom of the soil layer that include that head Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants