Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[FEATURE] Move giving testimonials to forms #7406

Open
5 tasks
eddiejaoude opened this issue Jun 6, 2023 · 7 comments
Open
5 tasks

[FEATURE] Move giving testimonials to forms #7406

eddiejaoude opened this issue Jun 6, 2023 · 7 comments

Comments

@eddiejaoude
Copy link
Member

eddiejaoude commented Jun 6, 2023

Description

Add a form to give someone else a testimonial

  • remove GitHub Action for testimonials
  • remove issue template for testimonials
  • list given testimonials on user's account
  • form to give a testimonial
  • list sent testimonials in manage section

Challenge: new testimonials for profiles are not loaded after forms are used on the profile separate issue #8794

Screenshots

No response

Additional information

No response

@eddiejaoude eddiejaoude added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/LinkFree/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
@amandamartin-dev
Copy link
Contributor

Some thoughts...

Does a testimonial-giver have to be verified in some way to be a real person? (Spam reduction, harmful posts to bully under fake names, etc)
Related to above: How do we prevent "system gaming". Ex. I want a TON of good reviews of myself so I leave them FOR myself under various pseudonyms.
How does a testimonial-receiver review? WIll there be a UI under account to review these?
basic form validations, character limits needed

@eddiejaoude
Copy link
Member Author

Thanks Amanda 👍 Great points, let me share my thoughts...

Does a testimonial-giver have to be verified in some way to be a real person? (Spam reduction, harmful posts to bully under fake names, etc)

GitHub account to log in. Is this enough verification?

Related to above: How do we prevent "system gaming". Ex. I want a TON of good reviews of myself so I leave them FOR myself under various pseudonyms.

They would need multiple GitHub accounts

How does a testimonial-receiver review? WIll there be a UI under account to review these?

Yes these will appear in their testimonial manage page and not enabled (see screenshot)

Screenshot 2023-06-20 at 07 44 19

basic form validations, character limits needed

yes 100% thank you

@amandamartin-dev
Copy link
Contributor

@eddiejaoude thank you! I didn't know we were limiting to GitHub only. I thought forms were so outside GitHub folks could leave testimonials. My thoughts are redacted unless we open it up 😂

@eddiejaoude
Copy link
Member Author

No problem @amandamartin-dev , it is good to double check everything - the sooner we discuss items the better, for example I am so glad you caught all those gaps I missed in my forms PR before it was merged ❤️

@eddiejaoude eddiejaoude added 💻 aspect: code undefined 🟥 priority: critical undefined 🔢 points: 5 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Aug 23, 2023
@EddieHubCommunity EddieHubCommunity unlocked this conversation Sep 8, 2023
@chiranjeevkapoor
Copy link

I want to work on this : )

@amandamartin-dev
Copy link
Contributor

I want to work on this : )

Hello! Sorry for the delay in responding here. I noticed that you are new to the community - welcome! We are so happy to have new contributors, but we do ask that you start out with a smaller issue to familiarize with the repo. Let us know if you need some help finding a good issue to start. We suggest looking for 1-2 point issues before moving on. If you have any questions, feel free to ask in Discord

@SaraJaoude SaraJaoude added 🔢 points: 8 undefined 🔒 staff only undefined and removed 🔢 points: 5 undefined labels Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants