core2.0 - Require EdgeTokenId instead of currencyCode throughout API #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
commented
Dec 6, 2023
src/types/types.ts
Outdated
| @@ -12,6 +12,12 @@ export * from './fake-types' | |||
| export * from './server-cleaners' | |||
| export * from './server-types' | |||
|
|
|||
| // --------------------------------------------------------------------- | |||
There was a problem hiding this comment.
balanceMap
saveTxMetadata takes params object
paullinator
force-pushed
the
paul/nullTokenId
branch
from
2a7097b to
1be57cb
Compare
paullinator
force-pushed
the
paul/nullTokenId
branch
7 times, most recently
from
c3c83c8 to
14609e9
Compare
paullinator
force-pushed
the
paul/nullTokenId
branch
from
14609e9 to
852e0d5
Compare
swansontec
force-pushed
the
paul/nullTokenId
branch
2 times, most recently
from
635384f to
f267746
Compare
swansontec
approved these changes
Jan 4, 2024
src/client-side.ts
Outdated
| @@ -107,7 +107,7 @@ shareData({ fixUsername }) | |||
| */ | |||
| export function streamTransactions( | |||
| this: InternalWalletMethods, | |||
| opts: EdgeStreamTransactionOptions = {} | |||
| opts: EdgeStreamTransactionOptions = { tokenId: null } | |||
There was a problem hiding this comment.
We should probably make the EdgeTokenIdOptions parameters mandatory. If the tokenId isn't allowed to be undefined, then the whole thing can't be undefined either.
swansontec
force-pushed
the
paul/nullTokenId
branch
from
f267746 to
a32a063
Compare
paullinator
force-pushed
the
paul/nullTokenId
branch
from
a32a063 to
35b72b3
Compare
paullinator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
#574
Description
none