-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE! Experiment stop files loading #627
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to successfully pass blank tx files up to GUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably work, but only "accidentally". This avoids doing an ls
on the directory, but it doesn't actually disable loading the files themselves. That happens in loadTxFiles
. Fortunately, without that initial ls
, loadTxFiles
just loops around uselessly and doesn't do anything. So, you've avoided most of the disk accesses, which means this would probably be OK for experimenting with.
To really be sure this works, I would go for the win and actually remove the call to loadTxFiles
, which happens in $internalStreamTransactions
. Then you know for sure we aren't loading any tx files from disk.
// if (isNew) created.push(combinedTx) | ||
// else if (files[txidHash] != null) changed.push(combinedTx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to do changed.push(combinedTx)
for every transaction, so the GUI still gets updates.
The idea here is to switch between onTxChanged
/ onNewTx
, but since we don't have files, we just want everything to go in the "existing" bucket. The if (files[txidHash] != null)
check was there to prevent crashes, but that's no longer needed thanks to your other changes.
71002b4
to
efff7ac
Compare
efff7ac
to
b41b3cf
Compare
Review whether this satisifies the experiment requirements for the attached asana task