Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE! Experiment stop files loading #627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented Nov 20, 2024

Review whether this satisifies the experiment requirements for the attached asana task


Copy link
Member

@paullinator paullinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to successfully pass blank tx files up to GUI

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably work, but only "accidentally". This avoids doing an ls on the directory, but it doesn't actually disable loading the files themselves. That happens in loadTxFiles. Fortunately, without that initial ls, loadTxFiles just loops around uselessly and doesn't do anything. So, you've avoided most of the disk accesses, which means this would probably be OK for experimenting with.

To really be sure this works, I would go for the win and actually remove the call to loadTxFiles, which happens in $internalStreamTransactions. Then you know for sure we aren't loading any tx files from disk.

Comment on lines +351 to +352
// if (isNew) created.push(combinedTx)
// else if (files[txidHash] != null) changed.push(combinedTx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to do changed.push(combinedTx) for every transaction, so the GUI still gets updates.

The idea here is to switch between onTxChanged / onNewTx, but since we don't have files, we just want everything to go in the "existing" bucket. The if (files[txidHash] != null) check was there to prevent crashes, but that's no longer needed thanks to your other changes.

@samholmes samholmes force-pushed the sam/perf-testing-no-transaction-files branch from 71002b4 to efff7ac Compare November 29, 2024 19:50
@samholmes samholmes force-pushed the sam/perf-testing-no-transaction-files branch from efff7ac to b41b3cf Compare December 2, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants