Paul/add pokt #610
Paul/add pokt #610
Conversation
src/ethereum/EthereumNetwork.ts
Outdated
| if (typeof apiKey === 'string') { | ||
| url = url.replace(match[0], apiKey) | ||
| } else { | ||
| throw new Error('Incorrect apikey type for RPC') |
There was a problem hiding this comment.
If the apiKey is one of the values in initOptions of cleanKey, and if cleanKey is a key in the initOptions, then the error message should state something like:
`Missing ${apiKey} in 'initOptions' for ${pluginId}`There was a problem hiding this comment.
apiKey can also be an array, that's what this clause was meant to catch. But i'll add another for the case of null
paullinator
force-pushed
the
paul/addPokt
branch
2 times, most recently
from
54b8c91
to
63a8996
Compare
| } else if (apiKey == null) { | ||
| throw new Error( | ||
| `Missing ${cleanKey} in 'initOptions' for ${this.ethEngine.currencyInfo.pluginId}` | ||
| ) | ||
| } else { | ||
| throw new Error('Incorrect apikey type for RPC') |
There was a problem hiding this comment.
I looked at the type for apiKey and it looks like it could be an array of strings. Shouldn't we handle this case for evmScanApiKey? Maybe a simple random pick of one the keys
There was a problem hiding this comment.
No. Evmscan servers are not an RPC servers but a completely different "type". This PR is only for RPC servers and I don't want to scope creep the PR. That would also require another hour of testing.
There was a problem hiding this comment.
Ah, didn’t catch that difference. Thanks for correcting me here
paullinator
force-pushed
the
paul/addPokt
branch
from
63a8996
to
92d1d39
Compare
|
/rebase |
github-actions
bot
force-pushed
the
paul/addPokt
branch
from
92d1d39
to
066db4d
Compare
paullinator
force-pushed
the
paul/addPokt
branch
from
066db4d
to
b16faaa
Compare
CHANGELOG
added: Pokt network RPC servers
Dependencies
noneDescription
none