Cosmos hardfork support #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
force-pushed
the
matthew/thorchain-hardfork
branch
from
1aeb752 to
163a0bc
Compare
paullinator
requested changes
Aug 7, 2024
| if (this.networkInfo.chainIdUpdateUrl != null) { | ||
| try { | ||
| const res = await this.fetchCors(this.networkInfo.chainIdUpdateUrl) | ||
| const raw = await res.json() |
There was a problem hiding this comment.
check !res.ok send throw await res.text() to get better details on failure
src/cosmos/CosmosEngine.ts
Outdated
| this.otherData[query]?.newestTxid !== newestTxid | ||
| ) { | ||
| this.otherData[query] = { newestTxid } | ||
| this.otherData.archivedTxLastCheckTime = lastTimestamp |
There was a problem hiding this comment.
Setting archivedTxLastCheckTime inside the for loop of txQueryStrings could cause the receiver query type to not execute since archivedTxLastCheckTime is global to both send and receive queries
| for (const clients of clientsList) { | ||
| const { newestTxid, lastTimestamp } = await this.queryTransactionsInner( | ||
| query, | ||
| clients |
There was a problem hiding this comment.
Removing the starting page seems to mean you'll be querying all transactions every time and not continuing from where you left off.
paullinator
approved these changes
Aug 9, 2024
src/cosmos/CosmosEngine.ts
Outdated
| @@ -559,7 +557,10 @@ export class CosmosEngine extends CurrencyEngine< | |||
| this.otherData[query]?.newestTxid !== newestTxid | |||
| ) { | |||
| this.otherData[query] = { newestTxid } | |||
| this.otherData.archivedTxLastCheckTime = lastTimestamp | |||
| this.otherData.archivedTxLastCheckTime = Math.max( | |||
There was a problem hiding this comment.
approved with requested small change of only setting archivedTxLastCheckTime once both send and recv transactions sycned.
peachbits
force-pushed
the
matthew/thorchain-hardfork
branch
from
3e5113b to
00761cf
Compare
This adds support for multiple archive nodes, which is necessary to support a chain over multiple hardforks.
peachbits
force-pushed
the
matthew/thorchain-hardfork
branch
from
00761cf to
534bf2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none