Downgrade OS support #4475
Closed
Downgrade OS support #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/downgrade-os-support
branch
from
d84016f
to
8ce4d6b
Compare
swansontec
force-pushed
the
william/downgrade-os-support
branch
from
8ce4d6b
to
82f0597
Compare
|
After a few hours of effort, it doesn't look like we can get Zcash working on these older OS versions without crashing. Yes, it's supposed to be possible to conditionalize these things, but doing so will require deep refactoring to third-party code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Dependencies
With this change, we can run the app again on these OS's. However, we are now getting a crash on iOS 12.4. Removing RNZcash fixes the crash, so now we need to debug RNZcash and implement a fix over there.
Requirements
If you have made any visual changes to the GUI. Make sure you have: