Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tarot pools with 5x leverage #4675

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Add Tarot pools with 5x leverage #4675

merged 7 commits into from
Jan 16, 2024

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Jan 3, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@samholmes
Copy link
Contributor

Missing CHANGELOG entry?

Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the feedback. I also added some fixups of my own when I reviewed

Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's review bar

Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved even though the MaUint256 stuff stays the same

They are hardly, if ever, used, but the infrastructure is there in case new plugins need to use these options.
This is the same functionality used in edge-currency-accountbased ported over. It's an overestimate because we have to use some hardcoded gas limit values for transactions that cannot be estimated.
Previous commit set to 2x. This increases it to 5x and adds leverage data to unique identifiers
@peachbits peachbits merged commit 0f49f86 into develop Jan 16, 2024
2 checks passed
@peachbits peachbits deleted the matthew/tarotLeverage branch January 16, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants