-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tarot pools with 5x leverage #4675
Conversation
Missing CHANGELOG entry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for all the feedback. I also added some fixups of my own when I reviewed
src/plugins/stake-plugins/generic/pluginInfo/optimismTarotPool.ts
Outdated
Show resolved
Hide resolved
src/plugins/stake-plugins/generic/pluginInfo/optimismTarotPool.ts
Outdated
Show resolved
Hide resolved
src/plugins/stake-plugins/generic/pluginInfo/optimismTarotPool.ts
Outdated
Show resolved
Hide resolved
e45b764
to
729c698
Compare
729c698
to
ef050d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's review bar
319db24
to
5585edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved even though the MaUint256 stuff stays the same
They are hardly, if ever, used, but the infrastructure is there in case new plugins need to use these options.
This is the same functionality used in edge-currency-accountbased ported over. It's an overestimate because we have to use some hardcoded gas limit values for transactions that cannot be estimated.
Previous commit set to 2x. This increases it to 5x and adds leverage data to unique identifiers
12b9378
to
b5d365b
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: