Add promo cards to HomeScene #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/ui4/promo-card-int
branch
from
02b0d87 to
35b3150
Compare
paullinator
requested changes
Jan 6, 2024
| <EdgeAnim style={{ height: theme.rem(11.5) }} enter={{ type: 'fadeInUp', distance: 30 }}> | ||
| <CarouselUi4 height={theme.rem(10)} width={screenWidth}> | ||
| {promos.map(promoInfo => ( | ||
| <PromoCardUi4 navigation={navigation} promoInfo={promoInfo} key={promoInfo.localeMessages[0]} /> |
There was a problem hiding this comment.
Shouldn't this be localeMessages[language] or something like that
There was a problem hiding this comment.
It's just the key and we're guaranteed the first localeMessage
There was a problem hiding this comment.
But we shouldn't be using the first message. We should be using the one that matches the language.
There was a problem hiding this comment.
We should be using the language, not the first entry. That's why we even have a localeMessage in the first place.
Jon-edge
force-pushed
the
jon/ui4/promo-card-int
branch
from
35b3150 to
f54125a
Compare
|
Close functionality is broken in that the Punted and created a spinoff task: https://app.asana.com/0/1200382638405084/1206315466361645/f |
Jon-edge
force-pushed
the
jon/ui4/promo-card-int
branch
from
1d206b3 to
201713e
Compare
paullinator
reviewed
Jan 10, 2024
paullinator
reviewed
Jan 10, 2024
src/components/ui4/PromoCardsUi4.tsx
Outdated
| if (osVersions != null && osVersions.length > 0 && !osVersions.includes(osVersion.toString())) return false | ||
|
|
||
| // Validate date range | ||
| const startDate = startIsoDate != null && !isNaN(Date.parse(startIsoDate)) ? new Date(startIsoDate) : null |
There was a problem hiding this comment.
Iso dates can be lexographically compared. No need to convert with new Date. Just do
const currentIsoDate = new Date().toISOString()
if (startIsoDate > currentIsoDate) return false
if (endIsoDate < currentIsoDate) return false
paullinator
requested changes
Jan 10, 2024
Jon-edge
force-pushed
the
jon/ui4/promo-card-int
branch
4 times, most recently
from
8eca0c3 to
a16e808
Compare
paullinator
force-pushed
the
jon/ui4/promo-card-int
branch
from
a16e808 to
26d9544
Compare
paullinator
requested changes
Jan 11, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Broken visuals attached.
|
Jon-edge
force-pushed
the
jon/ui4/promo-card-int
branch
from
c1bf673 to
bca3f70
Compare
Jon-edge
force-pushed
the
jon/ui4/promo-card-int
branch
7 times, most recently
from
d85b635 to
60e971a
Compare
paullinator
approved these changes
Jan 12, 2024
paullinator
approved these changes
Jan 12, 2024
Clean up style logic and add mini button. - Rename styles to make it more clear. - Since we need different padding and height for mini buttons, make sure marginRem and paddingRem are always last in the styles list so they can continue to override built-in layouts.
Per UI4's split 0.5rem spacing expectations, roll those margins into CarouselUi4 so it always goes outside of those margins horizontally to fill up 100% of the width.
- Fixed height, accomodating a maximum of 4 lines of text. Potentially adjusted once average content length is given. - No text shrinking for readability.
Pending close button functionality
Jon-edge
force-pushed
the
jon/ui4/promo-card-int
branch
from
60e971a to
1425f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending close button functionality
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: