Jon/ui4/marketing-video #4720
Jon/ui4/marketing-video #4720
Conversation
|
Please add screen shots in show balance and hide balance mode |
|
Yeah, PR wasn't ready yet with screens so it wasn't assigned yet |
Jon-edge
force-pushed
the
jon/ui4/marketing-video
branch
from
2e2788b
to
3dc3085
Compare
| @@ -159,23 +156,6 @@ export class TransactionListTopComponent extends React.PureComponent<Props, Stat | |||
| this.setState({ lockedNativeAmount }) | |||
| } | |||
|
|
|||
| handleOpenWalletListModal = () => { | |||
There was a problem hiding this comment.
When was it decided to remove this functionality? Unless there was consent (I had not heard of such), please put it back
There was a problem hiding this comment.
It was decided earlier on with Madison but has since reverted the decision since we're retaining this functionality in the new design. Will revert
| marginTop: theme.rem(1), | ||
| flexDirection: 'row' | ||
| flexDirection: 'row', | ||
| justifyContent: 'space-evenly' |
There was a problem hiding this comment.
I'm guessing this like changed the button layout from left justified. Given that the buttons have no border, it looks a bit weird to me and I'm on the fence about the change. If this was approved by design, then ok, otherwise I'd like to revert back.
There was a problem hiding this comment.
I don't see the relation between borders and left justification? Left justification seems less friendly to internationals, and the spacing always looked strange to me in this section.
I just did a fine tune session with Madison and we tweaked it a bit to ignore the card's built in spacing. She also likes this centered style better than the legacy layout. Screens updated.
Jon-edge
force-pushed
the
jon/ui4/marketing-video
branch
from
0f31ba6
to
9f5fb9a
Compare
It's already obvious they're tappable and the UI looks busy with sharp contrasting chevrons
Unable to utilize row or card's built-in icon and text handling for some reason in this case. Quick fix instead.
Jon-edge
force-pushed
the
jon/ui4/marketing-video
branch
from
9f5fb9a
to
c010e56
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: