Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jon/fix/login-reporting #4948

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Jon/fix/login-reporting #4948

merged 1 commit into from
Apr 2, 2024

Conversation

Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Mar 29, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@Jon-edge Jon-edge force-pushed the jon/light-buy-50 branch 2 times, most recently from 220476c to 756e087 Compare March 29, 2024 23:24
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but do not hit merge yet! Something is messed up with your branch, so please fix that up (maybe a rebase or something) before you merge the PR.

@Jon-edge Jon-edge changed the base branch from jon/light-buy-50 to develop April 2, 2024 05:12
@Jon-edge
Copy link
Collaborator Author

Jon-edge commented Apr 2, 2024

Got all turned around with a bunch of checkouts while debugging for this task, somehow messed up the base. Not sure why block-wip-pr is failing though...

@Jon-edge Jon-edge merged commit 77d9049 into develop Apr 2, 2024
1 of 2 checks passed
@Jon-edge Jon-edge deleted the jon/fix/login-reporting branch April 2, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants