Make the AirshipDropdown component swipeable #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/swipe-dropdown
branch
from
f8ebee4 to
04c0c2a
Compare
paullinator
force-pushed
the
william/swipe-dropdown
branch
from
6ef6b57 to
cfcdc44
Compare
paullinator
approved these changes
Jan 16, 2024
| <TouchableWithoutFeedback onPress={onPress ?? handleClose}> | ||
| <Animated.View style={[styles.body, bodyStyle]}>{children}</Animated.View> | ||
| </TouchableWithoutFeedback> | ||
| </GestureDetector> |
There was a problem hiding this comment.
I know there's no design for this, but the dropdown should have a horizontal drag bar to indicate draggability like we have on bottom up modals. I pushed an extra commit that implements this
paullinator
force-pushed
the
william/swipe-dropdown
branch
from
cfcdc44 to
821b30f
Compare
swansontec
force-pushed
the
william/swipe-dropdown
branch
from
821b30f to
ef80860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: