Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paul/fix buy quote #4719

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Paul/fix buy quote #4719

merged 2 commits into from
Jan 18, 2024

Conversation

paullinator
Copy link
Member

@paullinator paullinator commented Jan 17, 2024 •
edited
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@paullinator
Copy link
Member Author

Screenshot 2024-01-16 at 17 32 02 Screenshot 2024-01-16 at 17 34 44

paullinator
paullinator commented Jan 17, 2024
View reviewed changes
src/plugins/gui/scenes/FiatPluginEnterAmountScene.tsx
@@ -1,6 +1,6 @@
import * as React from 'react'
import { useEffect } from 'react'
import { Image, Text, View } from 'react-native'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review this in 'hide whitespace' mode for simplicity

@paullinator
Copy link
Member Author

Screenshot 2024-01-16 at 17 45 35

@paullinator paullinator force-pushed the paul/fixBuyQuote branch 2 times, most recently from 073e8f9 to d49f0be Compare January 17, 2024 01:52
@paullinator paullinator force-pushed the paul/fixBuyQuote branch 2 times, most recently from 6b342e8 to dacbbf2 Compare January 18, 2024 01:47
@paullinator paullinator enabled auto-merge January 18, 2024 21:30
@paullinator paullinator merged commit a20ac66 into develop Jan 18, 2024
2 checks passed
@paullinator paullinator deleted the paul/fixBuyQuote branch January 18, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jon-edge Jon-edge Jon-edge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paullinator @Jon-edge