Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SceneWrapper, header, and footer #4721

Merged
merged 22 commits into from
Jan 18, 2024
Merged

Refactor SceneWrapper, header, and footer #4721

merged 22 commits into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. Rename "drawer" files to "footer" files

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    84ed435 View commit details
    Browse the repository at this point in the history

  2. Migrate naming to "footer" for scene drawer

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ae432d6 View commit details
    Browse the repository at this point in the history

  3. Fix useLayoutHeightInFooter state management with useIsFocused

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4444fea View commit details
    Browse the repository at this point in the history

  4. Fix SceneWrapper insets.bottom to include footerHeight 

    The `insetStyles` should simply be a convenient set of padding styles
derived from the `insets` without modification to the values.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    755acf6 View commit details
    Browse the repository at this point in the history

  5. Refactor SceneWrapper insets for readability 

    Instead of long summations of terms with separate conditions inline, we
factor out each term and its respective condition to make the logic
easy to reason about and maintain.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    5cf1488 View commit details
    Browse the repository at this point in the history

  6. Abstract common BlurView into BlurBackground component

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6f85511 View commit details
    Browse the repository at this point in the history

  7. De-pluralize insetStyles and other style prop values in SceneWrapper 

    A style is a set of rules. It was a mistake to name this property in
the plural form.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1af3eb2 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary hasKeyboardAnimation boolean 

    We can use `avoidKeyboard` prop directly to know if we are in this mode
in the `SceneWrapper`.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f153cb5 View commit details
    Browse the repository at this point in the history

  9. Add ability to reset SceneScrollState 

    Some scenes don't register the scroll handler and therefore don't have
local scroll state to stomp on the global scroll state. In this case,
they'll be left with another scene's scroll state.

To fix this, we set the scroll state back to its default scroll state
when the scene is no longer in focus.

We also fix a bug where local state never stomps on scrollXDelta
and scrollYDelta.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3cedab7 View commit details
    Browse the repository at this point in the history

  10. Convert SceneWrapper to always apply inset padding 

    This change makes for a more straight forward API where the scene
component may always expect padding and scene wrapper size to be
applied consistently. The scene is responsible for applying negative
margins using `undoInsetStyle` if it wishes to overlap under UI
components (header/tabs/etc).
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9de42b1 View commit details
    Browse the repository at this point in the history

  11. Fixed WiredProgressBar position

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4698113 View commit details
    Browse the repository at this point in the history

  12. Fix sorting on WalletListScene

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2d0d474 View commit details
    Browse the repository at this point in the history

  13. Add transparent black background to BlurHeader on Android 

    We add a black transparent background on Android to BlurBackground for
presentation consistency across platforms.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    77b8d6e View commit details
    Browse the repository at this point in the history

  14. Fix SceneWrapper layoutStyle measurements on Android

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    55b3bfc View commit details
    Browse the repository at this point in the history

  15. Fix SceneFooter bottom positioning issue concerning insets 

    Before we were adding a minimum padding to the bottom of the MenuTabs.
This clearly caused bugs. The new approach is to just use the bottom
inset for the bottom padding in the MenuBar so that way the SceneFooter
can include it in position calculations.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    48a9f43 View commit details
    Browse the repository at this point in the history

  16. Make Android navigation bar transparent

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ed32b8a View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary hasTabs={false} props

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9d0b8a8 View commit details
    Browse the repository at this point in the history

  18. Remove unnecessary hasHeader props

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    06dde9c View commit details
    Browse the repository at this point in the history

  19. Replace FlashList with FlatList components for all scenes

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7f1727f View commit details
    Browse the repository at this point in the history

  20. Fix scroll bar in middle of screen issue for SceneWrapper ScrollView

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c1908f9 View commit details
    Browse the repository at this point in the history

  21. Move NotificationView to footer and footer outside of ScrollView

    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8e0f5be View commit details
    Browse the repository at this point in the history

  22. Make BlurBackground's background tint consistent across platforms 

    We remove the overlayColor property from BlurBackground which is
Android-only. Instead, we add a backgroundColor to the blur view to
match the light/dark modes in iOS.
    @samholmes
    samholmes committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ecbd4b0 View commit details
    Browse the repository at this point in the history