Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paul/coinhub fixes2 #5195

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Paul/coinhub fixes2 #5195

merged 3 commits into from
Aug 13, 2024

Conversation

paullinator
Copy link
Member

@paullinator paullinator commented Aug 9, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@Jon-edge
Copy link
Collaborator

Jon-edge commented Aug 10, 2024

Is there a way to fix the actual crash?

Need more context as to why this is the solution, seems very heavy-handed to disable all swaps and UI. Also web3 handle and swap have no organizational association, yet they are linked in this disable functionality.

If coinhub does not support swaps and FIO, and for the flag to describe coinhub (or better, use APP_CONFIG), since the association between FIO and swap doesn't make sense. There's two separate configurations introduced for fio and swap yet the only place they are used they are linked.

@paullinator paullinator merged commit fb93f9d into develop Aug 13, 2024
2 checks passed
@paullinator paullinator deleted the paul/coinhubFixes2 branch August 13, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants