Lock Android to portrait mode #5355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already locked for iOS
swansontec
approved these changes
Nov 11, 2024
| @@ -43,6 +43,7 @@ | |||
| <activity | |||
| android:name=".MainActivity" | |||
| android:label="@string/app_name" | |||
| android:screenOrientation="portrait" | |||
There was a problem hiding this comment.
Can we put comments in here? Since this is a template file that comes from React Native, we could easily delete this line during an upgrade. So, we need to say "Edge addition: Fix for resolution issue" or something like that.
|
Per meeting, this won't work. We'd need to dynamically listen to resolution changes and refresh the theme. The Patina library has logic for handling theme changes dynamically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: