Skip to content

Commit

Permalink
Help CocoaPods find our missing header file
Browse files Browse the repository at this point in the history
Compiling with `use_frameworks!` exposes the fact that we forgot to include zcashlc.h in our podspec. Move it to a better location, then add it in.
  • Loading branch information
swansontec committed May 23, 2024
1 parent 46e0a77 commit 8ffda4b
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/android/build/
/ios/libzcashlc.xcframework/
/ios/ZCashLightClientKit/
/ios/zcashlc.h
/lib/
/tmp/

Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- fixed: Add a missing header file to the podspec.

## 0.7.2 (2024-05-17)

- fixed: Pause synchronizer events until JavaScript is ready to receive them.
Expand Down
2 changes: 1 addition & 1 deletion ios/react-native-zcash-Bridging-Header.h
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#import <React/RCTEventEmitter.h>
#include "ZCashLightClientKit/Rust/zcashlc.h"
#include "zcashlc.h"
1 change: 1 addition & 0 deletions react-native-zcash.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Pod::Spec.new do |s|
"ios/react-native-zcash-Bridging-Header.h",
"ios/RNZcash.m",
"ios/RNZcash.swift",
"ios/zcashlc.h",
"ios/ZCashLightClientKit/**/*.swift"
s.resource_bundles = {
"zcash-mainnet" => "ios/ZCashLightClientKit/Resources/checkpoints/mainnet/*.json",
Expand Down
2 changes: 1 addition & 1 deletion scripts/updateSources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ async function copySwift(): Promise<void> {

// Copy the Rust header into the Swift location:
await disklet.setText(
'ios/ZCashLightClientKit/Rust/zcashlc.h',
'ios/zcashlc.h',
await disklet.getText(
'tmp/zcash-light-client-ffi/releases/XCFramework/libzcashlc.xcframework/ios-arm64/libzcashlc.framework/Headers/zcashlc.h'
)
Expand Down

0 comments on commit 8ffda4b

Please sign in to comment.