Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Doesn't respect animateTransitions bool #350

Closed
QasimXAli opened this issue Oct 28, 2024 · 1 comment
Closed

[Bug] Doesn't respect animateTransitions bool #350

QasimXAli opened this issue Oct 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@QasimXAli
Copy link

QasimXAli commented Oct 28, 2024

Description

So found a bug where it doesn't respect animateTransitions true when the firstPageProgressIndicatorBuilder is lets say a shimmer but the list is empty and it shows the default texts for no more items. it doesn't animate from firstPageProgressIndicatorBuilder child to no more items default no more items texts.

Package Version

4.0.0

Platform

Android, iOS

Code sample

Code sample
                      PagedSliverList(
                        pagingController: controller
                            .bookmarkArtPostPaginatedProvider.pagingController,
                        builderDelegate: PagedChildBuilderDelegate<String>(
                          animateTransitions: true,
                          itemBuilder: (context, artId, index) {
                            return BehaviorSubjectBuilder<ArtPost?>(
                                subject: controller.$artPostById(artId),
                                builder: (context, snapshot) {
                                  if (!snapshot.hasData) {
                                    return const SizedBox.shrink();
                                  }
                                  final artPost = snapshot.data!;
                                  return const Placeholder();
                                });
                          },
                          newPageProgressIndicatorBuilder: (context) =>
                              const CustomLoader(),
                          firstPageProgressIndicatorBuilder: (context) =>
                              Column(
                            children: List.generate(5, (index) {
                              return const ArtItemShimmerWidget();
                            }),
                          ),
                        ),
                      ),
@QasimXAli QasimXAli added the bug Something isn't working label Oct 28, 2024
@clragon
Copy link
Collaborator

clragon commented Feb 2, 2025

Thank you for bringing this issue to our attention. I have fixed animating between first page loading, error and empty pages in the new package version 5.
At the current moment, it seems animating between new page loading indiactors, errors and items is also not functional, due to how these are built internally. Right now I cannot come up with a solution for that.

@clragon clragon closed this as completed Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants