Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Incorrect calculate_hits documentation #93

Open
MauritsDescamps opened this issue Jun 28, 2022 · 0 comments · May be fixed by #132
Open

[BUG] Incorrect calculate_hits documentation #93

MauritsDescamps opened this issue Jun 28, 2022 · 0 comments · May be fixed by #132
Labels
bug Something isn't working

Comments

@MauritsDescamps
Copy link
Contributor

The docstring of calculate_hits in BorutaShap.py states the following:

Percentile : value ranging from 0-1

This should be

Percentile : value ranging from 0-100

since numpy.percentile expects a percentage.
@MauritsDescamps MauritsDescamps added the bug Something isn't working label Jun 28, 2022
cbonet added a commit to cbonet/Boruta-Shap that referenced this issue Sep 30, 2024
@cbonet
Changed docstring of calculate_hits to address Ekeany#93. Removed non…
132dcd5 
… existent argument, added simple description and return type.
@cbonet cbonet linked a pull request Sep 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed docstring of calculate_hits to address #93. cbonet/Boruta-Shap
1 participant
@MauritsDescamps