Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Randomize train/test split #97

Open
MauritsDescamps opened this issue Jul 13, 2022 · 0 comments
Open

[ENH] Randomize train/test split #97

MauritsDescamps opened this issue Jul 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@MauritsDescamps
Copy link
Contributor

MauritsDescamps commented Jul 13, 2022 •
edited
Loading

Randomize train/test split

The random_state argument in BorutaShap.fit is set to 0 by default. This means that the train/test split performed in Check_if_chose_train_or_test_and_train_model is the same for every iteration. For the shadow features this doesn't really matter, but for the real features is means that the same subset of the data is used for training at every iteration. Is this by design, or would it be better to perform a random split each iteration?
@MauritsDescamps MauritsDescamps added the enhancement New feature or request label Jul 13, 2022
@MauritsDescamps MauritsDescamps changed the title [ENH] [ENH] Randomize train/test split Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MauritsDescamps