Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Early stopping criterion #98

Open
MauritsDescamps opened this issue Jul 14, 2022 · 0 comments
Open

[ENH] Early stopping criterion #98

MauritsDescamps opened this issue Jul 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@MauritsDescamps
Copy link
Contributor

The algorithm will only stop early if all features have been rejected (self.X.shape[1] == 0). It might be a good idea to also stop when there are no more tentative features, i.e all features that have not been rejected are confirmed important.
@MauritsDescamps MauritsDescamps added the bug Something isn't working label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MauritsDescamps