Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon should allow multiple innerBoundaryIs elements #6

Open
cbotman opened this issue Jan 29, 2013 · 3 comments
Open

Polygon should allow multiple innerBoundaryIs elements #6

cbotman opened this issue Jan 29, 2013 · 3 comments

Comments

@cbotman
Copy link

cbotman commented Jan 29, 2013

Hi there,

Thanks for your great work on this library.

I encountered a KML file that would not parse. The issue is the file had more than one Polygon->innerBoundaryIs element. I checked the KML spec, and this is indeed valid (and Google Earth loaded it up fine). https://developers.google.com/kml/documentation/kmlreference#polygon

The fix is easy to make. In com.ekito.simpleKML.model.Polygon.java, I changed:

    /** The inner boundary is. */
    @Element(required=false)
    private Boundary innerBoundaryIs;

to

    /** The inner boundary is list. */
    @ElementList(name="innerBoundaryIs", entry="innerBoundaryIs", inline=true, type=Boundary.class, required=false)
    private List<Boundary> innerBoundaryIsList;

And added the appropriate getter and setter for innerBoundaryIsList.

Hope this helps.

Thanks again.
@cbotman
Copy link
Author

cbotman commented Jan 29, 2013

Sorry it's so long, but here's an example of a Placemark that caused the problem.

    <Placemark>
      <description>B2; Shale, sandstone</description>
      <styleUrl>#area1</styleUrl>
      <Polygon>
        <outerBoundaryIs>
          <LinearRing>
            <coordinates>
              119.0320662845,-24.6001430501,0
              119.0317304515,-24.6003378977,0
              119.0013813182,-24.6164476521,0
              118.9865324099,-24.6243262180,0
              118.9538147796,-24.6451251487,0
              118.8658811280,-24.6897364602,0
              118.8232393904,-24.7069954409,0
              118.7794210224,-24.7197567671,0
              118.7669346185,-24.7218045083,0
              118.7631605467,-24.7239860962,0
              118.7494216138,-24.7260133261,0
              118.7406427850,-24.7292306068,0
              118.7043950669,-24.7364949653,0
              118.6806785494,-24.7394833590,0
              118.6532406977,-24.7412713259,0
              118.5847607033,-24.7412776692,0
              118.4976656568,-24.7386839354,0
              118.4156710317,-24.7305493964,0
              118.4093751467,-24.7337916695,0
              118.4141945990,-24.7405956936,0
              118.4252494925,-24.7474981314,0
              118.4238858686,-24.7530674199,0
              118.4162619846,-24.7596515359,0
              118.3963805069,-24.7581736605,0
              118.3852254232,-24.7557464587,0
              118.3640423354,-24.7564807991,0
              118.3327133236,-24.7648602845,0
              118.3138647474,-24.7723488031,0
              118.3074860885,-24.7789504993,0
              118.3086220762,-24.7834503605,0
              118.3122760882,-24.7868711767,0
              118.3221411647,-24.7915195359,0
              118.3357515504,-24.7951328470,0
              118.3928580548,-24.8039936258,0
              118.4338768680,-24.8080727115,0
              118.4662543978,-24.8086375140,0
              118.4997761363,-24.8136942190,0
              118.5084219967,-24.8171956849,0
              118.5169961559,-24.8240489930,0
              118.5254752142,-24.8353907185,0
              118.5373320536,-24.8551791131,0
              118.5613545134,-24.8593823602,0
              118.5800453647,-24.8646080226,0
              118.5992446227,-24.8698365529,0
              118.6262579128,-24.8788016700,0
              118.6497344370,-24.8870413303,0
              118.6704251781,-24.8952516609,0
              118.6868248258,-24.9020455163,0
              118.7047286595,-24.9104543684,0
              118.7200857490,-24.9199829649,0
              118.7268307293,-24.9287455147,0
              118.7297750180,-24.9372446345,0
              118.7294303667,-24.9450270516,0
              118.7237349603,-24.9548222118,0
              118.7155234112,-24.9627622864,0
              118.6976898028,-24.9690107454,0
              118.6768682876,-24.9704205572,0
              118.6562687665,-24.9743486335,0
              118.6318884485,-24.9761766045,0
              118.6080441523,-24.9757159738,0
              118.5854445488,-24.9770960645,0
              118.5636174304,-24.9775647210,0
              118.5468762760,-24.9771661801,0
              118.5225188136,-24.9771451474,0
              118.5047356099,-24.9787920850,0
              118.4882390891,-24.9790766591,0
              118.4757828103,-24.9807764907,0
              118.4607670555,-24.9840507887,0
              118.4442153044,-24.9882229789,0
              118.4273698986,-24.9951382203,0
              118.4125429036,-25.0027609815,0
              118.4010620469,-25.0069846256,0
              118.3880149075,-25.0141669244,0
              118.3782588343,-25.0218431710,0
              118.3732802311,-25.0325498721,0
              118.3685746819,-25.0418854315,0
              118.3640586445,-25.0555740152,0
              118.3618197093,-25.0697463812,0
              118.3618619942,-25.0841735305,0
              118.3657368678,-25.0970413066,0
              118.3698431834,-25.1115145527,0
              118.3767609044,-25.1248744358,0
              118.3854383853,-25.1396276991,0
              118.3969421322,-25.1523509734,0
              118.4044257267,-25.1620518913,0
              118.4149528851,-25.1722440664,0
              118.4393578222,-25.1896855219,0
              118.4578609910,-25.1933201881,0
              118.4750945327,-25.1969391150,0
              118.4913249980,-25.1996296222,0
              118.5016984093,-25.2031733807,0
              118.5136347549,-25.2039846821,0
              118.5260978603,-25.2034266099,0
              118.5446576109,-25.2031586658,0
              118.5639977505,-25.2015224568,0
              118.5833550801,-25.1985099598,0
              118.6009003244,-25.1979962415,0
              118.6199873150,-25.1961214622,0
              118.6339908614,-25.1941956379,0
              118.6454327898,-25.1938471027,0
              118.6578517785,-25.1967129169,0
              118.6715503472,-25.1989026800,0
              118.6857382967,-25.2026987545,0
              118.6997222676,-25.2023698155,0
              118.7175242195,-25.2016161352,0
              118.7322787744,-25.2006040794,0
              118.7419287718,-25.2013772656,0
              118.7518065054,-25.2044416566,0
              118.7670273403,-25.2070943771,0
              118.7822512832,-25.2095166636,0
              118.7997686716,-25.2114991103,0
              118.8150064975,-25.2127732964,0
              118.8363077209,-25.2175313143,0
              118.8492565947,-25.2190120898,0
              118.8648110596,-25.2145593734,0
              118.8732208404,-25.2125664463,0
              118.8808726993,-25.2101090833,0
              118.8864836941,-25.2083220584,0
              118.8900468921,-25.2078924114,0
              118.8915360673,-25.2113390640,0
              118.8938021709,-25.2134179293,0
              118.9037105633,-25.2139541221,0
              118.9161702760,-25.2135936253,0
              118.9289049328,-25.2111734457,0
              118.9411330567,-25.2085192307,0
              118.9546087314,-25.2081633889,0
              118.9683340562,-25.2082662345,0
              118.9815398760,-25.2095089204,0
              118.9924606366,-25.2105048908,0
              119.0031099485,-25.2133300579,0
              119.0160408159,-25.2168576614,0
              119.0286970026,-25.2226721735,0
              119.0403331737,-25.2289364468,0
              119.0497076979,-25.2324363775,0
              119.0603683809,-25.2343416766,0
              119.0720710068,-25.2335054681,0
              119.0776803227,-25.2317115315,0
              119.0815222462,-25.2285316238,0
              119.0849409201,-25.2157313813,0
              119.0891477782,-25.1999596317,0
              119.0933494680,-25.1846456655,0
              119.0972940906,-25.1695588440,0
              119.1029920690,-25.1572312908,0
              119.1099593683,-25.1449119584,0
              119.1202195706,-25.1335296119,0
              119.1319845369,-25.1242169878,0
              119.1475785134,-25.1124089482,0
              119.1626523360,-25.1017408974,0
              119.1729462887,-25.0927773331,0
              119.1751860581,-25.0908267737,0
              119.1899878506,-25.0817571915,0
              119.1997095044,-25.0726560648,0
              119.2014431191,-25.0705889491,0
              119.2102183035,-25.0601243864,0
              119.2250440581,-25.0471593809,0
              119.2403955517,-25.0314482132,0
              119.2503946792,-25.0182240570,0
              119.2583545889,-25.0059037452,0
              119.2660627450,-24.9931235480,0
              119.2729980125,-24.9817127714,0
              119.2776354157,-24.9721209818,0
              119.2817531306,-24.9641290916,0
              119.2871717648,-24.9515645516,0
              119.2893101515,-24.9364630853,0
              119.2931868602,-24.9264085273,0
              119.3067435191,-24.9210558526,0
              119.3069203109,-24.9209860025,0
              119.3252125335,-24.9162727319,0
              119.3538569192,-24.9180207949,0
              119.3764409741,-24.9158415950,0
              119.3995430033,-24.9118296175,0
              119.4157789371,-24.9107598126,0
              119.4317778089,-24.9069395301,0
              119.4449660357,-24.9065399840,0
              119.4634962836,-24.9031854281,0
              119.4802519749,-24.8995923405,0
              119.4949578478,-24.8996528515,0
              119.5074006266,-24.8962682438,0
              119.5170600495,-24.8917268265,0
              119.5221455259,-24.8889988881,0
              119.5279839627,-24.8876476787,0
              119.5302463086,-24.8913200955,0
              119.5306886883,-24.8931173602,0
              119.5314873395,-24.8963624738,0
              119.5207941616,-24.9045644741,0
              119.5073077826,-24.9132125644,0
              119.4869672520,-24.9227473886,0
              119.4663806418,-24.9304466845,0
              119.4478655736,-24.9305958320,0
              119.4311047048,-24.9341854250,0
              119.4186829088,-24.9332134808,0
              119.4044874736,-24.9320031812,0
              119.3882590687,-24.9314690252,0
              119.3684787981,-24.9311447791,0
              119.3540183105,-24.9317606033,0
              119.3425837568,-24.9349090517,0
              119.3311345045,-24.9401175667,0
              119.3242514798,-24.9451199104,0
              119.3170885326,-24.9537840765,0
              119.3096547052,-24.9647362819,0
              119.3029643238,-24.9779818197,0
              119.2957682287,-24.9907663555,0
              119.2890899509,-25.0019505722,0
              119.2831951450,-25.0099331249,0
              119.2760054454,-25.0213431318,0
              119.2708432935,-25.0329928222,0
              119.2626136402,-25.0473732138,0
              119.2556634118,-25.0601572184,0
              119.2500038523,-25.0699715319,0
              119.2464801469,-25.0754471021,0
              119.2438372794,-25.0795536250,0
              119.2326052955,-25.0872747783,0
              119.2201077333,-25.0943007795,0
              119.2086227748,-25.1015607743,0
              119.1965972619,-25.1127095084,0
              119.1873799594,-25.1218134537,0
              119.1768558607,-25.1352595468,0
              119.1694044257,-25.1455181156,0
              119.1624486791,-25.1571533410,0
              119.1565117548,-25.1683366154,0
              119.1505604303,-25.1811224307,0
              119.1479156679,-25.1934709262,0
              119.1488498858,-25.2033231248,0
              119.1538511392,-25.2132007824,0
              119.1553095273,-25.2212243060,0
              119.1554989263,-25.2290109518,0
              119.1561834843,-25.2384035524,0
              119.1586555862,-25.2468913641,0
              119.1649460292,-25.2549447659,0
              119.1758260495,-25.2616521855,0
              119.1908056427,-25.2647198003,0
              119.2042816716,-25.2650292397,0
              119.2190620831,-25.2609943943,0
              119.2285158727,-25.2550956298,0
              119.2359506765,-25.2471239090,0
              119.2415845602,-25.2418894336,0
              119.2474652591,-25.2375721482,0
              119.2622330856,-25.2346780062,0
              119.2749393151,-25.2354350092,0
              119.2835780770,-25.2361689335,0
              119.2881192815,-25.2410021024,0
              119.2873182882,-25.2462643707,0
              119.2768537185,-25.2517031951,0
              119.2669122875,-25.2550834355,0
              119.2508643219,-25.2588866675,0
              119.2403870549,-25.2656968753,0
              119.2329551609,-25.2732108395,0
              119.2262819877,-25.2811868455,0
              119.2193590632,-25.2884741676,0
              119.2137373241,-25.2918760351,0
              119.2088369071,-25.3005487006,0
              119.2039084063,-25.3124270804,0
              119.2038179347,-25.3236470485,0
              119.2082907028,-25.3369549424,0
              119.2127537417,-25.3516363668,0
              119.2172582339,-25.3612799221,0
              119.2336359874,-25.3496963883,0
              119.2451677681,-25.3392284586,0
              119.2577097216,-25.3294523121,0
              119.2735634336,-25.3187774497,0
              119.2901922705,-25.3060443652,0
              119.3045394411,-25.2916947837,0
              119.3212247024,-25.2697996018,0
              119.3368846064,-25.2483555020,0
              119.3481977148,-25.2298649666,0
              119.3605225825,-25.2116076917,0
              119.3713266225,-25.1921971733,0
              119.3831231414,-25.1759963742,0
              119.3969757555,-25.1556826750,0
              119.4102969676,-25.1383421444,0
              119.4261613367,-25.1198669897,0
              119.4420195019,-25.1016192105,0
              119.4637147035,-25.0831659325,0
              119.4792746985,-25.0708666596,0
              119.4614896287,-25.0728522901,0
              119.4482743515,-25.0748559133,0
              119.4329052932,-25.0746057695,0
              119.4442612307,-25.0665951205,0
              119.4549639251,-25.0600012804,0
              119.4720304264,-25.0502278838,0
              119.5005740559,-25.0301950971,0
              119.5211896992,-25.0197436262,0
              119.5387555459,-25.0095069022,0
              119.5581154282,-24.9951531602,0
              119.5810268763,-24.9798933465,0
              119.5998696052,-24.9655326071,0
              119.6176973839,-24.9504791615,0
              119.6367917117,-24.9349695499,0
              119.6640022735,-24.9181081264,0
              119.6899344599,-24.9016963860,0
              119.7040024789,-24.8908157265,0
              119.7120592431,-24.8845830638,0
              119.7361995133,-24.8693037264,0
              119.7593209157,-24.8537894076,0
              119.7852086787,-24.8430860961,0
              119.8113398622,-24.8342107371,0
              119.8379676588,-24.8276216859,0
              119.8635628019,-24.8272087482,0
              119.8914279674,-24.8311453504,0
              119.9122006224,-24.8343807871,0
              119.9372757369,-24.8410534352,0
              119.9661440867,-24.8539085312,0
              119.9866558511,-24.8651480473,0
              120.0005723627,-24.8814172758,0
              120.0013780072,-24.8838241865,0
              120.0066297940,-24.8995113238,0
              120.0053322345,-24.9194315795,0
              120.0013787166,-24.9313802434,0
              119.9997270504,-24.9363716111,0
              119.9885421023,-24.9519328205,0
              119.9750814708,-24.9615375339,0
              120.0013791507,-24.9470556548,0
              120.0316410158,-24.9566914821,0
              120.0501762841,-24.9590772821,0
              120.0760484940,-24.9593463229,0
              120.0818128705,-24.9517485251,0
              120.0891190076,-24.9464283627,0
              120.0995053802,-24.9452057461,0
              120.1073683687,-24.9453753108,0
              120.1202923717,-24.9443609423,0
              120.1337558350,-24.9467755039,0
              120.1489773619,-24.9473434689,0
              120.1641900492,-24.9469942684,0
              120.1695487675,-24.9503857677,0
              120.1749325854,-24.9562952640,0
              120.1828257839,-24.9594369222,0
              120.1919715019,-24.9609654050,0
              120.2033678218,-24.9592697362,0
              120.2137193314,-24.9546055313,0
              120.2227857687,-24.9483487551,0
              120.2295597671,-24.9411947996,0
              120.2381078755,-24.9340256128,0
              120.2451289644,-24.9264109720,0
              120.2529313333,-24.9208498314,0
              120.2599412445,-24.9123188288,0
              120.2677179733,-24.9044676725,0
              120.2709165789,-24.8952820803,0
              120.2708368542,-24.8877274001,0
              120.2712736697,-24.8810840469,0
              120.2737258394,-24.8732784965,0
              120.2792648406,-24.8697961275,0
              120.2860485819,-24.8642421527,0
              120.2859875044,-24.8585188927,0
              120.2831586710,-24.8546513988,0
              120.2777961032,-24.8508059504,0
              120.2706796169,-24.8488071708,0
              120.2658316475,-24.8456436814,0
              120.2629988043,-24.8413180730,0
              120.2619012764,-24.8333141488,0
              120.2575584501,-24.8299172121,0
              120.2494039354,-24.8254077983,0
              120.2432836942,-24.8215676777,0
              120.2389135317,-24.8154229105,0
              120.2385847147,-24.8080992956,0
              120.2377400686,-24.7998641383,0
              120.2376951853,-24.7955144401,0
              120.2376150695,-24.7877308079,0
              120.2357574811,-24.7795041691,0
              120.2311662125,-24.7763375077,0
              120.2300519846,-24.7756504955,0
              120.2182267787,-24.7742517465,0
              120.2045204581,-24.7741688604,0
              120.1833935138,-24.7684452940,0
              120.1772225584,-24.7616992120,0
              120.1773150407,-24.7505017372,0
              120.1973987850,-24.7316064590,0
              120.2074094562,-24.7249601240,0
              120.2186449009,-24.7216627052,0
              120.2360599268,-24.7240057773,0
              120.2279613945,-24.7152173030,0
              120.2194645035,-24.7028596606,0
              120.2173920855,-24.6920987499,0
              120.2140562232,-24.6824953504,0
              120.2081698003,-24.6735026154,0
              120.1965581374,-24.6668774814,0
              120.1867462603,-24.6636458283,0
              120.1866941515,-24.6700011550,0
              120.1679549746,-24.6788311454,0
              120.1417388011,-24.6876217963,0
              120.1005625795,-24.6985355617,0
              120.0443468771,-24.7194043469,0
              120.0406256169,-24.7182636802,0
              120.0406988454,-24.7104309619,0
              120.0532389026,-24.7004476326,0
              120.0745110006,-24.6882842383,0
              120.0995120848,-24.6772689134,0
              120.1182359654,-24.6706756102,0
              120.1382001180,-24.6652134564,0
              120.1703869244,-24.6584918026,0
              120.1592805799,-24.6549914740,0
              120.1438120516,-24.6467209439,0
              120.1353661838,-24.6371988369,0
              120.1320763079,-24.6304338657,0
              120.1319616716,-24.6219129775,0
              120.1312151466,-24.6139703802,0
              120.1246831613,-24.6038485175,0
              120.1203846863,-24.6001430501,0
              119.2658883075,-24.6001430501,0
              119.2254028300,-24.6230101160,0
              119.2015214529,-24.6383772342,0
              119.1701442806,-24.6547597264,0
              119.1463409201,-24.6645264314,0
              119.1300993543,-24.6687832497,0
              119.1176417091,-24.6697457491,0
              119.1176417091,-24.6697457491,0
              119.1164461989,-24.6663762440,0
              119.1189926775,-24.6630445958,0
              119.1452313322,-24.6566791314,0
              119.1602695592,-24.6501541338,0
              119.2092455089,-24.6216830302,0
              119.2437838688,-24.6001430501,0
              119.0320662845,-24.6001430501,0
            </coordinates>
          </LinearRing>
        </outerBoundaryIs>
        <innerBoundaryIs>
          <LinearRing>
            <coordinates>
              119.2139524594,-24.7951784341,0
              119.1778558593,-24.7935977144,0
              119.1704502558,-24.7890355716,0
              119.1706509011,-24.7767263481,0
              119.1809348549,-24.7567128513,0
              119.1872981942,-24.7489610016,0
              119.1986547401,-24.7390435126,0
              119.2552703073,-24.7016956412,0
              119.2979868961,-24.6764743939,0
              119.3117668356,-24.6699309025,0
              119.3192544548,-24.6689053601,0
              119.3217112601,-24.6711625883,0
              119.3228828649,-24.6756556885,0
              119.3190694348,-24.6812039914,0
              119.3039356818,-24.6944506548,0
              119.2737572619,-24.7142328930,0
              119.2323105300,-24.7372239454,0
              119.2121748337,-24.7503995634,0
              119.1894159864,-24.7713717576,0
              119.1893257428,-24.7769638003,0
              119.1967491808,-24.7804113311,0
              119.2091815908,-24.7816929946,0
              119.2266351894,-24.7807853234,0
              119.2441239193,-24.7776477979,0
              119.2653964123,-24.7711894546,0
              119.2716211465,-24.7712652247,0
              119.2765196980,-24.7769176117,0
              119.2739577826,-24.7813658678,0
              119.2638778975,-24.7890759416,0
              119.2413846561,-24.7932795748,0
              119.2139524594,-24.7951784341,0
            </coordinates>
          </LinearRing>
        </innerBoundaryIs>
        <innerBoundaryIs>
          <LinearRing>
            <coordinates>
              119.1391563412,-24.7986932945,0
              119.1317146159,-24.7963684184,0
              119.1193749278,-24.7894885363,0
              119.1095352730,-24.7815267498,0
              119.1059341974,-24.7736464807,0
              119.1060468477,-24.7669406706,0
              119.1087643649,-24.7535393437,0
              119.1126270829,-24.7457685686,0
              119.1202894984,-24.7346714968,0
              119.1303918010,-24.7258567514,0
              119.1454751869,-24.7171056891,0
              119.2031337146,-24.6932169511,0
              119.2294814690,-24.6801192106,0
              119.2457395437,-24.6747263975,0
              119.2544502075,-24.6748332781,0
              119.2569058351,-24.6771028447,0
              119.2568536304,-24.6804559800,0
              119.2278405012,-24.7047117149,0
              119.2027035281,-24.7200638394,0
              119.1562772554,-24.7418574906,0
              119.1449415426,-24.7495439182,0
              119.1410989917,-24.7562012991,0
              119.1421723857,-24.7662876811,0
              119.1519762293,-24.7764864642,0
              119.1555801037,-24.7843656499,0
              119.1542665804,-24.7888278255,0
              119.1441479768,-24.7976439168,0
              119.1391563412,-24.7986932945,0
            </coordinates>
          </LinearRing>
        </innerBoundaryIs>
        <innerBoundaryIs>
          <LinearRing>
            <coordinates>
              118.7453002398,-24.8725196965,0
              118.7291614203,-24.8689146954,0
              118.7167931848,-24.8642416972,0
              118.7094005777,-24.8596576105,0
              118.6984221380,-24.8482866716,0
              118.6777763195,-24.8211068223,0
              118.6753736728,-24.8166007693,0
              118.6743602409,-24.8053868436,0
              118.6770340063,-24.7964827712,0
              118.6846341561,-24.7898967147,0
              118.6959562791,-24.7844720510,0
              118.7059700649,-24.7824023965,0
              118.7271356102,-24.7827350801,0
              118.7569084730,-24.7887912301,0
              118.7990056409,-24.8017367416,0
              118.8040963630,-24.8002792516,0
              118.8237069337,-24.8133073577,0
              118.8334964141,-24.8224008437,0
              118.8407430739,-24.8348205987,0
              118.8442444393,-24.8471729141,0
              118.8440118034,-24.8594811813,0
              118.8363816167,-24.8672000935,0
              118.8238389451,-24.8714798483,0
              118.8151159070,-24.8713486279,0
              118.8052164706,-24.8678454097,0
              118.8002928894,-24.8644174033,0
              118.7917864072,-24.8531020048,0
              118.7894658547,-24.8441085410,0
              118.7858401196,-24.8384600929,0
              118.7859050246,-24.8351073906,0
              118.7786766812,-24.8226852219,0
              118.7725463523,-24.8169979769,0
              118.7614561301,-24.8112340747,0
              118.7503103370,-24.8077083275,0
              118.7366284910,-24.8063699833,0
              118.7328732908,-24.8074370366,0
              118.7277769726,-24.8129503210,0
              118.7338261157,-24.8219915619,0
              118.7436441055,-24.8299771432,0
              118.7533412658,-24.8435532445,0
              118.7544847546,-24.8491641177,0
              118.7593277470,-24.8559576435,0
              118.7604058269,-24.8649209119,0
              118.7540451174,-24.8715412447,0
              118.7453002398,-24.8725196965,0
            </coordinates>
          </LinearRing>
        </innerBoundaryIs>
      </Polygon>
    </Placemark>

@romainpiel
Copy link
Contributor

Hey mate,
Your code is looking good. Please make a pull request, I'll review it and integrate it in the libe.
Cheers

@cbotman
Copy link
Author

cbotman commented Jan 31, 2013

Hey,

I'll take a crack at doing that soon--otherwise you are welcome to recreate the change.

I confess I don't actually know how to use Git yet (entirely due to a lack of time)... I'm still stuck in the world of SVN so I downloaded the project as a Zip file. :)

Regards,
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romainpiel @cbotman