Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all the symlinks smtp_queue_fs::scan_folder #79

Open
Ekleog opened this issue May 13, 2020 · 0 comments
Open

Validate all the symlinks smtp_queue_fs::scan_folder #79

Ekleog opened this issue May 13, 2020 · 0 comments
Labels
a:smtp-queue-fs Area: in the smtp-queue-fs crate c:easy Complexity: easy n:dev Needs: development work p:medium Prio: medium t:improvement Type: existing feature's improvement

Comments

@Ekleog
Copy link
Owner

Ekleog commented May 13, 2020

This doesn't have to be a security feature, just to avoid user error.

Idea: check that each symlink's targets point to something in ../data with Path::starts_with. Something similar is already being done during mail cleanup, to rmdir the folder out.
@Ekleog Ekleog added t:improvement Type: existing feature's improvement c:easy Complexity: easy p:medium Prio: medium n:dev Needs: development work a:smtp-queue-fs Area: in the smtp-queue-fs crate labels May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:smtp-queue-fs Area: in the smtp-queue-fs crate c:easy Complexity: easy n:dev Needs: development work p:medium Prio: medium t:improvement Type: existing feature's improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ekleog