Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sdk requirement #13

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Update sdk requirement #13

merged 4 commits into from
Feb 22, 2024

Conversation

PierreGauthier
Copy link
Contributor

Q A
Branch? master for features / current stable version branch for bug fixes
Tickets #...
License OSL-3.0

@PierreGauthier
Copy link
Contributor Author

Waiting a new version of the sdk to be release
(Elastic-Suite/gally-php-rest-sdk#5)

@shochdoerfer
Copy link
Collaborator

Not necessarily part of this PR but I think it would be good if the SDK would check if the required Gally server version matches. There have been some bigger changes in the last few months and not knowing if the SDK matches the server version could cause some issues, I think. And probably hard to debug issues (for people not so deep into Gally).

@PierreGauthier PierreGauthier marked this pull request as ready for review February 22, 2024 16:54
@PierreGauthier PierreGauthier force-pushed the feat-updateBranch branch 2 times, most recently from ce8da60 to 9d51a9e Compare February 22, 2024 17:36
@PierreGauthier PierreGauthier merged commit 9634749 into master Feb 22, 2024
1 check passed
@PierreGauthier PierreGauthier deleted the feat-updateBranch branch February 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierreGauthier @shochdoerfer