From 519fc755c304ae17afe45ba3b9757f462d1171d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Enrique=20Jim=C3=A9nez?= Date: Sun, 5 Jan 2025 21:17:58 +0000 Subject: [PATCH] Add Digitale Keilschrift Bibliothek to External Nos --- .../ManuscriptPopover.test.tsx.snap | 2 +- src/fragmentarium/domain/Fragment.test.ts | 1 + src/fragmentarium/domain/FragmentDtos.ts | 1 + .../LatestTransliterations.test.tsx.snap | 42 +++--- .../ui/info/ExternalNumberLink.tsx | 15 ++ .../ui/info/ExternalResources.test.tsx | 8 ++ .../ui/info/ExternalResources.tsx | 5 + .../ExternalResources.test.tsx.snap | 12 ++ .../FragmentariumSearch.test.tsx.snap | 128 ++++++++++-------- src/test-support/fragment-data-fixtures.tsx | 2 + src/test-support/test-fragment.ts | 1 + .../ui/__snapshots__/markup.test.tsx.snap | 2 +- 12 files changed, 134 insertions(+), 85 deletions(-) diff --git a/src/corpus/ui/__snapshots__/ManuscriptPopover.test.tsx.snap b/src/corpus/ui/__snapshots__/ManuscriptPopover.test.tsx.snap index 417e322d3..6a122325b 100644 --- a/src/corpus/ui/__snapshots__/ManuscriptPopover.test.tsx.snap +++ b/src/corpus/ui/__snapshots__/ManuscriptPopover.test.tsx.snap @@ -19,7 +19,7 @@ exports[`Show manuscript line details 1`] = ` - Estrada & Wolfe, 2069: 7477711662481408-4847418310918144 + Estrada & Wolfe, 2070: 7477711662481408-4847418310918144 [ l. 4'.2., 3'. ] diff --git a/src/fragmentarium/domain/Fragment.test.ts b/src/fragmentarium/domain/Fragment.test.ts index 6ef1f0635..f8a6859b6 100644 --- a/src/fragmentarium/domain/Fragment.test.ts +++ b/src/fragmentarium/domain/Fragment.test.ts @@ -127,6 +127,7 @@ const config: Parameters[0] = { hilprechtHeidelbergNumber: '123', achemenetNumber: '123', nabuccoNumber: '123', + digitaleKeilschriftBibliothekNumber: '123', metropolitanNumber: '123', louvreNumber: '123', dublinTcdNumber: '123', diff --git a/src/fragmentarium/domain/FragmentDtos.ts b/src/fragmentarium/domain/FragmentDtos.ts index 16600e15a..87b0936c0 100644 --- a/src/fragmentarium/domain/FragmentDtos.ts +++ b/src/fragmentarium/domain/FragmentDtos.ts @@ -72,6 +72,7 @@ export const ExternalNumberTypes = [ 'hilprechtHeidelbergNumber', 'achemenetNumber', 'nabuccoNumber', + 'digitaleKeilschriftBibliothekNumber', 'metropolitanNumber', 'louvreNumber', 'dublinTcdNumber', diff --git a/src/fragmentarium/ui/front-page/__snapshots__/LatestTransliterations.test.tsx.snap b/src/fragmentarium/ui/front-page/__snapshots__/LatestTransliterations.test.tsx.snap index 5abcb6fb5..56f1eddbb 100644 --- a/src/fragmentarium/ui/front-page/__snapshots__/LatestTransliterations.test.tsx.snap +++ b/src/fragmentarium/ui/front-page/__snapshots__/LatestTransliterations.test.tsx.snap @@ -37,11 +37,11 @@ exports[`Snapshot 1`] = `

Excavation no.: - waloub.1 + am.1

Provenance: - Dilbat + Irisagrig

@@ -80,9 +80,9 @@ exports[`Snapshot 1`] = ` , ) @@ -129,7 +129,7 @@ exports[`Snapshot 1`] = ` - Fanti & Carr, 2037: 8970824935538688-3796097900216320 + Fanti & Carr, 2038: 8970824935538688-3796097900216320 [ l. 4'.2., 2. ] @@ -144,7 +144,7 @@ exports[`Snapshot 1`] = ` - Hall & Reid, 2090: 7020923936833536-4895425479835648 + Hall & Reid, 2091: 7020923936833536-4895425479835648 [ l. 4'.2., 3'. ] @@ -5851,9 +5851,9 @@ exports[`Snapshot 1`] = ` class="fragment-result__fragment-number" > - hapbig.2 + ewipidmif.2 (JN) @@ -5863,15 +5863,15 @@ exports[`Snapshot 1`] = `

Accession no.: - pehuvu.2 + uwhewjo.2

Excavation no.: - uf.2 + gi.2

Provenance: - Ḫuzirina + Tepe Gotvand

@@ -5899,17 +5899,7 @@ exports[`Snapshot 1`] = `
  • - Cavallini - ( - Transliteration - , - - - ) + No record
    • @@ -5954,7 +5944,7 @@ exports[`Snapshot 1`] = ` - Checcucci & Tomlinson, 2026: 4727451873705984-8024100712742912 + Checcucci & Tomlinson, 2027: 4727451873705984-8024100712742912 [ l. 3'., 1. ] @@ -5973,14 +5963,14 @@ exports[`Snapshot 1`] = ` - Chirici & Borchi, 2055: 851575803215872-8906036102561792 + Chirici & Borchi, 2110: 7824054333472768-2832266722017280 [ - l. 1., 2. + l. 3'., 4'.2. ] - (D) + (E) diff --git a/src/fragmentarium/ui/info/ExternalNumberLink.tsx b/src/fragmentarium/ui/info/ExternalNumberLink.tsx index dc82e80e4..817a8c0fb 100644 --- a/src/fragmentarium/ui/info/ExternalNumberLink.tsx +++ b/src/fragmentarium/ui/info/ExternalNumberLink.tsx @@ -125,6 +125,21 @@ export function NabuccoLink({ number }: { number: string }): JSX.Element { /> ) } +export function DigitaleKeilschriftBibliothekLink({ + number, +}: { + number: string +}): JSX.Element { + return ( + + ) +} export function MetropolitanLink({ number }: { number: string }): JSX.Element { return ( { hilprechtHeidelbergNumber, achemenetNumber, nabuccoNumber, + digitaleKeilschriftBibliothekNumber, metropolitanNumber, louvreNumber, dublinTcdNumber, @@ -88,6 +90,11 @@ describe('external resources', () => { 'https://nabucco.acdh.oeaw.ac.at/archiv/tablet/detail/', nabuccoNumber, ], + [ + 'Digitale Keilschrift Bibliothek', + 'https://gwdu64.gwdg.de/pls/tlinnemann/keilpublic_1$tafel.QueryViewByKey?', + digitaleKeilschriftBibliothekNumber, + ], [ 'The Metropolitan Museum of Art', 'https://www.metmuseum.org/art/collection/search/', @@ -152,6 +159,7 @@ describe('missing external resources', () => { 'Hilprecht Collection – HeiCuBeDa', 'Achemenet', 'NaBuCCo', + 'Digitale Keilschrift Bibliothek', 'The Metropolitan Museum of Art', 'Louvre', 'Trinity College Dublin', diff --git a/src/fragmentarium/ui/info/ExternalResources.tsx b/src/fragmentarium/ui/info/ExternalResources.tsx index b6461bbdc..93522dd56 100644 --- a/src/fragmentarium/ui/info/ExternalResources.tsx +++ b/src/fragmentarium/ui/info/ExternalResources.tsx @@ -11,6 +11,7 @@ import { HilprechtHeidelbergLink, AchemenetLink, NabuccoLink, + DigitaleKeilschriftBibliothekLink, MetropolitanLink, LouvreLink, dublinTcdLink, @@ -53,6 +54,10 @@ export default function ExternalResources({ ], [fragment.getExternalNumber('achemenetNumber'), AchemenetLink], [fragment.getExternalNumber('nabuccoNumber'), NabuccoLink], + [ + fragment.getExternalNumber('digitaleKeilschriftBibliothekNumber'), + DigitaleKeilschriftBibliothekLink, + ], [fragment.getExternalNumber('metropolitanNumber'), MetropolitanLink], [fragment.getExternalNumber('louvreNumber'), LouvreLink], [fragment.getExternalNumber('dublinTcdNumber'), dublinTcdLink], diff --git a/src/fragmentarium/ui/info/__snapshots__/ExternalResources.test.tsx.snap b/src/fragmentarium/ui/info/__snapshots__/ExternalResources.test.tsx.snap index 9748ea19b..3036d3542 100644 --- a/src/fragmentarium/ui/info/__snapshots__/ExternalResources.test.tsx.snap +++ b/src/fragmentarium/ui/info/__snapshots__/ExternalResources.test.tsx.snap @@ -125,6 +125,18 @@ exports[`external resources Snapshot 1`] = ` ) +
  • + Digitale Keilschrift Bibliothek ( + + H00765 + + ) +
  • The Metropolitan Museum of Art ( - hohoru.9 + fufca.9 - (Par) + (MB)

    Accession no.: - id.9 + ver.9

    Excavation no.: - zajo.9 + fitob.9

    Provenance: - Meturan (Tell al-Sib) + Kisurra

    @@ -820,6 +820,11 @@ exports[`Searching fragments by transliteration Displays corpus results when cli class="text-secondary fragment-result__genre col-sm-4 col-12" >