Skip to content

Commit

Permalink
add Pierpont Morgan Number
Browse files Browse the repository at this point in the history
  • Loading branch information
zsomborfoldi committed Dec 21, 2024
1 parent ce14307 commit 8168cb9
Show file tree
Hide file tree
Showing 10 changed files with 122 additions and 78 deletions.
1 change: 1 addition & 0 deletions src/fragmentarium/domain/Fragment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ const config: Parameters<typeof Fragment['create']>[0] = {
achemenetNumber: '123',
nabuccoNumber: '123',
metropolitanNumber: '123',
pierpontMorganNumber: '123',
louvreNumber: '123',
dublinTcdNumber: '123',
alalahHpmNumber: '123',
Expand Down
1 change: 1 addition & 0 deletions src/fragmentarium/domain/FragmentDtos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export const ExternalNumberTypes = [
'achemenetNumber',
'nabuccoNumber',
'metropolitanNumber',
'pierpontMorganNumber',
'louvreNumber',
'dublinTcdNumber',
'alalahHpmNumber',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ exports[`Snapshot 1`] = `
</p>
<p>
Excavation no.:
waloub.1
am.1
</p>
<p>
Provenance:
Dilbat
Irisagrig
</p>
</small>
</div>
Expand Down Expand Up @@ -5851,9 +5851,9 @@ exports[`Snapshot 1`] = `
class="fragment-result__fragment-number"
>
<a
href="/fragmentarium/hapbig.2"
href="/fragmentarium/ewipidmif.2"
>
hapbig.2
ewipidmif.2
</a>
(JN)
</h4>
Expand All @@ -5863,15 +5863,15 @@ exports[`Snapshot 1`] = `
<small>
<p>
Accession no.:
pehuvu.2
uwhewjo.2
</p>
<p>
Excavation no.:
uf.2
gi.2
</p>
<p>
Provenance:
Ḫuzirina
Tepe Gotvand
</p>
</small>
</div>
Expand Down Expand Up @@ -5899,17 +5899,7 @@ exports[`Snapshot 1`] = `
<li
class="Record__entry"
>
Cavallini
(
Transliteration
,
<time
datetime="2061-06-11"
>
11/6/2061
</time>
)
No record
</li>
</ol>
</div>
Expand Down Expand Up @@ -5973,14 +5963,14 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Chirici & Borchi, 2055: 851575803215872-8906036102561792
Chirici & Borchi, 2109: 7824054333472768-2832266722017280
[
l. 1., 2.
l. 3'., 4'.2.
]
<span
class="type-abbreviation"
>
(D)
(E)
</span>
</span>
</li>
Expand Down
13 changes: 13 additions & 0 deletions src/fragmentarium/ui/info/ExternalNumberLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,19 @@ export function MetropolitanLink({ number }: { number: string }): JSX.Element {
/>
)
}
export function pierpontMorganLink({
number,
}: {
number: string
}): JSX.Element {
return (
<ExternalNumberLink
number={number}
baseUrl={'https://www.themorgan.org/seals-and-tablets/'}
label={'Pierpont Morgan Library'}
/>
)
}
export function LouvreLink({ number }: { number: string }): JSX.Element {
return (
<ExternalNumberLink
Expand Down
8 changes: 8 additions & 0 deletions src/fragmentarium/ui/info/ExternalResources.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const hilprechtHeidelbergNumber = 'H007'
const achemenetNumber = 'H00744'
const nabuccoNumber = 'H00765'
const metropolitanNumber = 'M123'
const pierpontMorganNumber = 'P123'
const louvreNumber = 'L123'
const dublinTcdNumber = 'L123'
const alalahHpmNumber = 'L123'
Expand Down Expand Up @@ -44,6 +45,7 @@ describe('external resources', () => {
achemenetNumber,
nabuccoNumber,
metropolitanNumber,
pierpontMorganNumber,
louvreNumber,
dublinTcdNumber,
alalahHpmNumber,
Expand Down Expand Up @@ -93,6 +95,11 @@ describe('external resources', () => {
'https://www.metmuseum.org/art/collection/search/',
metropolitanNumber,
],
[
'Pierpont Morgan Library',
'https://www.themorgan.org/seals-and-tablets/',
pierpontMorganNumber,
],
['Louvre', 'https://collections.louvre.fr/ark:/53355/', louvreNumber],
[
'Trinity College Dublin',
Expand Down Expand Up @@ -153,6 +160,7 @@ describe('missing external resources', () => {
'Achemenet',
'NaBuCCo',
'The Metropolitan Museum of Art',
'Pierpont Morgan Library',
'Louvre',
'Trinity College Dublin',
'Alalah HPM Number',
Expand Down
2 changes: 2 additions & 0 deletions src/fragmentarium/ui/info/ExternalResources.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
AchemenetLink,
NabuccoLink,
MetropolitanLink,
pierpontMorganLink,
LouvreLink,
dublinTcdLink,
alalahHpmLink,
Expand Down Expand Up @@ -54,6 +55,7 @@ export default function ExternalResources({
[fragment.getExternalNumber('achemenetNumber'), AchemenetLink],
[fragment.getExternalNumber('nabuccoNumber'), NabuccoLink],
[fragment.getExternalNumber('metropolitanNumber'), MetropolitanLink],
[fragment.getExternalNumber('pierpontMorganNumber'), pierpontMorganLink],
[fragment.getExternalNumber('louvreNumber'), LouvreLink],
[fragment.getExternalNumber('dublinTcdNumber'), dublinTcdLink],
[fragment.getExternalNumber('alalahHpmNumber'), alalahHpmLink],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,18 @@ exports[`external resources Snapshot 1`] = `
</a>
)
</li>
<li>
Pierpont Morgan Library (
<a
aria-label="Pierpont Morgan Library text P123"
href="https://www.themorgan.org/seals-and-tablets/P123"
rel="noopener noreferrer"
target="_blank"
>
P123
</a>
)
</li>
<li>
Louvre (
<a
Expand Down
Loading

0 comments on commit 8168cb9

Please sign in to comment.