From 8807a77a208097d767bcef4d3248e597297aae46 Mon Sep 17 00:00:00 2001
From: Ilya Khait <ilya.khait@lmu.de>
Date: Mon, 11 Mar 2024 20:38:45 +0000
Subject: [PATCH] Adjust placeholders

---
 src/fragmentarium/ui/ProvenanceSearchForm.tsx          | 5 +++--
 src/fragmentarium/ui/fragment/ColophonEditor.tsx       | 8 ++++++--
 src/fragmentarium/ui/fragment/ColophonEditorInputs.tsx | 5 +++++
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/fragmentarium/ui/ProvenanceSearchForm.tsx b/src/fragmentarium/ui/ProvenanceSearchForm.tsx
index 80ab2b3ad..df9494957 100644
--- a/src/fragmentarium/ui/ProvenanceSearchForm.tsx
+++ b/src/fragmentarium/ui/ProvenanceSearchForm.tsx
@@ -8,11 +8,12 @@ export default withData<
   {
     onChange: (value: string | null) => void
     value?: string | null
+    placeholder?: string
   },
   { fragmentService: FragmentService },
   ReadonlyArray<ReadonlyArray<string>>
 >(
-  ({ data, value, onChange }) => {
+  ({ data, value, placeholder, onChange }) => {
     const options = data.map((site) => ({
       value: site.join(' '),
       label: site.join(' '),
@@ -22,7 +23,7 @@ export default withData<
     return (
       <Select
         aria-label="select-provenance"
-        placeholder="Provenance"
+        placeholder={placeholder ?? 'Provenance'}
         options={options}
         value={defaultOption}
         onChange={(selection) => {
diff --git a/src/fragmentarium/ui/fragment/ColophonEditor.tsx b/src/fragmentarium/ui/fragment/ColophonEditor.tsx
index 933d24cd2..11c2cea8b 100644
--- a/src/fragmentarium/ui/fragment/ColophonEditor.tsx
+++ b/src/fragmentarium/ui/fragment/ColophonEditor.tsx
@@ -137,8 +137,11 @@ const ColophonEditor: React.FC<Props> = ({
   updateColophon,
   fragmentService,
 }) => {
-  // ToDo: Implement commented out
-  //const { colophon } = fragment
+  // ToDo:
+  // - Implement commented out as state attributes
+  // - Implement onChange for each input
+
+  // const { colophon } = fragment
   const [formData, setFormData] = useState<Colophon>({
     colophonStatus: ColophonStatus.No, //colophon?.colophonStatus || ColophonStatus.No,
     colophonOwnership: ColophonOwnership.Library, //fragment.colophon?.colophonOwnership || ColophonOwnership.Library,
@@ -220,6 +223,7 @@ const ColophonEditor: React.FC<Props> = ({
           return new Promise(() => empty)
         }}
       />
+      {/* ToDo: Implement `notes to scribal process as a text input field`*/}
       <Button
         variant="primary"
         type="submit"
diff --git a/src/fragmentarium/ui/fragment/ColophonEditorInputs.tsx b/src/fragmentarium/ui/fragment/ColophonEditorInputs.tsx
index 7b8f74082..f357edfe3 100644
--- a/src/fragmentarium/ui/fragment/ColophonEditorInputs.tsx
+++ b/src/fragmentarium/ui/fragment/ColophonEditorInputs.tsx
@@ -34,6 +34,7 @@ const ProvenanceAttestationInput = ({
         fragmentService={fragmentService}
         onChange={onChange}
         value={provenanceAttestation?.value?.name}
+        placeholder={_.startCase(name)}
       />
       <Row>
         <BrokenAndUncertainSwitches
@@ -64,6 +65,7 @@ export const ColophonStatusInput = ({
         value={{ value: colophonStatus, label: colophonStatus }}
         onChange={onChange('colophonStatus')}
         isClearable={true}
+        placeholder="Status"
       />
     </Form.Group>
   )
@@ -93,6 +95,7 @@ export const ColophonOwnershipInput = ({
         ]}
         onChange={onChange('colophonOwnership')}
         isClearable={true}
+        placeholder="Ownership"
       />
     </Form.Group>
   )
@@ -117,6 +120,7 @@ export const ColophonTypeInput = ({
         values={[{ value: colophonType ?? '', label: colophonType ?? '' }]}
         onChange={onChange}
         isClearable={true}
+        placeholder="Type"
       />
     </Form.Group>
   )
@@ -144,6 +148,7 @@ export const ColophonOriginalFromInput = ({
         setBroken,
         setUncertain,
         name: 'originalFrom',
+        placeholder: 'Ownership',
       }}
     />
   )