fix type errors

ElectronicBabylonianLiterature · Oct 26, 2023 · e7cb6a8 · e7cb6a8
1 parent 07d6fd3
commit e7cb6a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/fragmentarium/domain/FragmentDtos.ts b/src/fragmentarium/domain/FragmentDtos.ts
@@ -68,7 +68,7 @@ export const ExternalNumberTypes = [
 export type ExternalNumber = typeof ExternalNumberTypes[number]
 
 export type ExternalNumbers = {
-  [K in ExternalNumber]: string
+  [K in ExternalNumber]?: string
 }
 
 export default interface FragmentDto {

diff --git a/src/fragmentarium/domain/fragment.ts b/src/fragmentarium/domain/fragment.ts
@@ -232,7 +232,7 @@ export class Fragment {
   }
 
   private getExternalNumber(numberType: ExternalNumber): string {
-    return this.externalNumbers[numberType]
+    return this.externalNumbers[numberType] || ''
   }
 
   get cdliNumber(): string {