Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Aquatic) entities from other mods won't spawn #126

Closed
NinetyKnight99 opened this issue Feb 16, 2024 · 11 comments
Closed

(Aquatic) entities from other mods won't spawn #126

NinetyKnight99 opened this issue Feb 16, 2024 · 11 comments
Labels
enhancement New feature or request mod incompatibility Something isn't working with another mod

Comments

@NinetyKnight99
Copy link

NinetyKnight99 commented Feb 16, 2024

I was testing the mod and noticed in the ocean the problem of incompatibility continues with others mods.

those mods are: zoo and wild, better animal plus and abyssal deeps (other mods that add sea creatures such as animalium or ice and fire do not have that problem and the mobs do spawn)

the creatures from these mods do not spawn in the ocean, only the creatures from mo creatures .

I already tried the aforementioned mods separately along with the mo creatures mod, modifying the number of creatures that can spawn by lowering the values ​​of mo creatures and increasing the values ​​of the other mods and the problem persisted.

@ACGaming ACGaming added the bug Something isn't working label Feb 18, 2024
@ACGaming
Copy link
Member

Please test with this new build: https://github.com/ACGaming/MoCreaturesExtended/actions/runs/7949586490/artifacts/1254598783

Extract the .zip file and use the .jar file without the -dev tag.

There are two new config settings for that matter, please set WorldGenSpawningWaterCreatures in MoCSettings.cfg to false and test again.

@NinetyKnight99
Copy link
Author

I had problems with my equipment and I had to send it to be fixed, I was recently able to check the game again and I discovered that the mod is not the problem, it turns out that when I leave and enter the world the sea mobs from other mods already appear, this is some external error with another mod that causes the same error with other mods causing the creatures to not appear until one exits and re-enters the created world (I suspect the bug is from the zawa mod)

I apologize for the false alarm and the possible loss of time it causes.

@ACGaming
Copy link
Member

No worries, thanks for the explanation. From my testing, both spawning on land and in water is working fine with popular animal mods in the latest development state. Aquatic spawns are sophisticated, so chance is the developers of other water-related animal mods are doing something tricky to accomplish them.

@NinetyKnight99
Copy link
Author

NinetyKnight99 commented Mar 14, 2024

I have been doing more tests, I already removed all the mods, I already deleted all the configurations, I did tests without Zawa, using only the abyssaldephts and better animal plus mods and the error persisted.

I don't know what happened that caused animals from other mods and mo creatures to appear at the same time during one of the tests, but again the error returned.

If I remove the mo creatures mod, the animals from better animal pluss and abyssaldepths spawn again.

@ACGaming
Copy link
Member

Please test with this new build: https://github.com/ACGaming/MoCreaturesExtended/actions/runs/7949586490/artifacts/1254598783

Extract the .zip file and use the .jar file without the -dev tag.

There are two new config settings for that matter, please set WorldGenSpawningWaterCreatures in MoCSettings.cfg to false and test again.

Have you tried this yet?

Additionally, you can increase the limits of water creature spawns with Universal Tweaks as shown here:
Spawn Caps

@NinetyKnight99
Copy link
Author

Please test with this new build: https://github.com/ACGaming/MoCreaturesExtended/actions/runs/7949586490/artifacts/1254598783
Extract the .zip file and use the .jar file without the -dev tag.
There are two new config settings for that matter, please set WorldGenSpawningWaterCreatures in MoCSettings.cfg to false and test again.

Have you tried this yet?

Additionally, you can increase the limits of water creature spawns with Universal Tweaks as shown here: Spawn Caps

This mod makes my Minecraft always crashes and I can never open the game

@ACGaming
Copy link
Member

Did you install the necessary dependencies ConfigAnytime and MixinBooter as well?

@NinetyKnight99
Copy link
Author

Did you install the necessary dependencies ConfigAnytime and MixinBooter as well?

I did it and the same thing happened again, it worked for a few moments, animals from mo creatures and the other mods appeared at the same time, but from one moment to the next the glitch occurred again making marine animals from the other mods will stop spawning again.

@IcarussOne
Copy link
Member

Unfortunately aquatic mobs before 1.13 have different behavior for spawning and despawning even for vanilla. After quite a bit of testing though, there is some strange behaviors going on while Custom Water Creature Spawning is enabled so I would keep that disabled in the latest build and use a spawn tweaking mod like BiomeTweaker to amp up all the weights of the desired mobs from those other mods.

@IcarussOne IcarussOne added enhancement New feature or request and removed bug Something isn't working labels Apr 18, 2024
@IcarussOne IcarussOne pinned this issue Apr 18, 2024
@IcarussOne IcarussOne added mod incompatibility Something isn't working with another mod and removed enhancement New feature or request labels Apr 18, 2024
@ACGaming
Copy link
Member

ACGaming commented May 3, 2024

With our new config options WorldGenSpawningCreatures for regular creatures and WorldGenSpawningWaterCreatures for water creatures, our custom spawning during wold generation is disabled by default to improve compatibility with other mods adding entities. It's possible for the end user to enable these features to achieve a behavior resembling the classic Mo' Creatures feeling with vanilla-friendly means.

Other than that, spawning in our continuation is entirely handled by the vanilla spawning system which is balanced around weights: Entities are set to spawn in specific biomes with specific weights and a global spawn cap. The higher the weight of the respective entity, the more likely it is picked by the spawning system. As Mo' Creatures is adding 80+ creatures, it can effectively 'drown out' other mods' entities. To fine-tune this, we improved the configuration file MoCreatures.cfg located under ..\config\MoCreatures, giving the end user plenty of options to set spawn biomes, weights and the amounts spawned per iteration.

Water creatures are more special than land creatures, since vanilla spawning for water creatures is solely balanced around squids. Because of this, these entity type has a much smaller spawn cap than others. Changing the values for spawn caps requires coremodding which is not an inherent feature of Mo' Creatures itself. The end user can alter these spawn caps with the widely utilized mod Universal Tweaks as shown in this configuration example, emulating the spawn caps of the original Mo' Creatures:
Spawn Caps

With these mentioned tools, it's possible to thoroughly configure spawning of Mo' Creatures entities for any modpack use case. If that should still not suffice, there are additional mods such as In Control! or BiomeTweaker to control spawning of entities altogether.

@ACGaming ACGaming changed the title Aquatic entities from other mods won't spawn (Aquatic) entities from other mods won't spawn May 3, 2024
@IcarussOne
Copy link
Member

Should be resolved with default configurations.

@IcarussOne IcarussOne added the enhancement New feature or request label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mod incompatibility Something isn't working with another mod
Projects
None yet
Development

No branches or pull requests

3 participants