Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust to 1.60 #51

Merged
merged 1 commit into from
May 10, 2022
Merged

Bump rust to 1.60 #51

merged 1 commit into from
May 10, 2022

Conversation

MarcoIeni
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This action is failing in my project due to an issue with an old cargo version.

Can you release a new version of the action with an updated rust toolchain? 🙏

@MarcoIeni MarcoIeni requested a review from Jake-Shadle as a code owner May 9, 2022 21:02
@Jake-Shadle
Copy link
Member

The rust-version argument was explicitly added for this situation, can you not use that?

@MarcoIeni
Copy link
Contributor Author

yes, I noticed this after opening this PR. I will use that. Any reason why you don't want to use rust 1.60?

@Jake-Shadle
Copy link
Member

In this case it's not a big deal, but rust-version was added so that anyone could essentially unblock themselves rather than rely on getting a PR on this repo merged and released.

@MarcoIeni
Copy link
Contributor Author

I am now using this argument in my project, thanks! Feel free to merge or close this PR :)

@Jake-Shadle Jake-Shadle merged commit 08081c7 into EmbarkStudios:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants