Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to import Transaction into TxBuilder #521

Open
FinleyMcIlwaine opened this issue Sep 12, 2022 · 1 comment
Open

Ability to import Transaction into TxBuilder #521

FinleyMcIlwaine opened this issue Sep 12, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@FinleyMcIlwaine
Copy link

It would be nice if the TransactionBuilder API was able to "import" a pre-existing Transaction into the builder for further manipulation. Is there any reason this wouldn't be possible?

@vsubhuman vsubhuman added the enhancement New feature or request label Sep 13, 2022
@vsubhuman
Copy link
Contributor

Thank you for the request, @FinleyMcIlwaine! We'll look into trying to add this.

The only complication will be that internally the TransactionBuilder works by assuming many fields of the future transaction are empty or non-existing at the beginning and with initialising from an existing transaction that won't be true. For example, when the builder is called to calculate and add change if needed it calculates the fee size only if the value where not set before, with a pre-existing transaction the fee logically would also be already present. This might require some additional careful API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants