Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13.2.0 #704

Merged
merged 3 commits into from
Nov 14, 2024
Merged

13.2.0 #704

merged 3 commits into from
Nov 14, 2024

Conversation

lisicky
Copy link
Contributor

@lisicky lisicky commented Nov 14, 2024

Changes

Transaction Fee Calculation Updates

  • set_fee() now sets a static fee that remains unchanged during change calculation
    • TransactionBuilder.build_tx() will emit an error if minimal possible fee exceeds specified fee
  • New set_min_fee() method added
    • Sets minimum fee threshold
    • If minimal possible fee is lower, uses the specified minimum fee value

Additional Validation

  • Added balance validation in build_tx()
  • Added collateral balance check in set_total_collateral_and_return()

@lisicky lisicky requested a review from vsubhuman November 14, 2024 14:19
lisicky
lisicky commented Nov 14, 2024
View reviewed changes
Copy link
Contributor Author

@lisicky lisicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman added this to the 13.2.0 milestone Nov 14, 2024
@lisicky lisicky merged commit a2a19db into master Nov 14, 2024
5 checks passed
@lisicky lisicky deleted the 13.2.0 branch November 14, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lisicky @vsubhuman