From d84671b404d11937b58ee619e6fe43208d4af7a3 Mon Sep 17 00:00:00 2001
From: banklesss <105349292+banklesss@users.noreply.github.com>
Date: Fri, 30 Aug 2024 16:07:52 +0200
Subject: [PATCH] refactor(catalyst): split the generation of voting tx and
 voting key (#3581)

---
 .../useCases/ConfirmPin/ConfirmPin.tsx        | 69 +++++++++++++++++--
 .../ConfirmVotingTx/ConfirmVotingTx.tsx       |  8 +--
 .../yoroi-wallets/cardano/cardano-wallet.ts   | 15 +---
 .../src/yoroi-wallets/cardano/types.ts        |  4 +-
 .../src/yoroi-wallets/hooks/index.ts          | 11 ++-
 .../src/catalyst/translators/context.tsx      |  5 ++
 .../src/catalyst/translators/state.test.tsx   | 26 ++++++-
 .../src/catalyst/translators/state.tsx        | 16 +++++
 8 files changed, 121 insertions(+), 33 deletions(-)

diff --git a/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmPin/ConfirmPin.tsx b/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmPin/ConfirmPin.tsx
index 2bbc805fdb..78c66b9195 100644
--- a/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmPin/ConfirmPin.tsx
+++ b/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmPin/ConfirmPin.tsx
@@ -1,23 +1,36 @@
 import {useCatalyst} from '@yoroi/staking'
 import {useTheme} from '@yoroi/theme'
 import React from 'react'
-import {ScrollView, StyleSheet, View, ViewProps} from 'react-native'
+import {ActivityIndicator, ScrollView, StyleSheet, View, ViewProps} from 'react-native'
 import {SafeAreaView} from 'react-native-safe-area-context'
+import {useMutation, UseMutationOptions} from 'react-query'
 
 import {Button, Spacer} from '../../../../components'
 import {BACKSPACE, NumericKeyboard} from '../../../../components/NumericKeyboard'
 import {Space} from '../../../../components/Space/Space'
+import {generatePrivateKeyForCatalyst} from '../../../../yoroi-wallets/cardano/catalyst'
+import {encryptWithPassword} from '../../../../yoroi-wallets/cardano/catalyst/catalystCipher'
 import {useNavigateTo} from '../../CatalystNavigator'
 import {Actions, Description, PinBox, Row, Stepper} from '../../common/components'
 import {useStrings} from '../../common/strings'
 
 export const ConfirmPin = () => {
   const strings = useStrings()
+  const {isDark} = useTheme()
   const styles = useStyles()
-  const {pin} = useCatalyst()
+  const {pin, votingKeyEncryptedChanged, catalystKeyHexChanged} = useCatalyst()
   const navigateTo = useNavigateTo()
   const [currentActivePin, setCurrentActivePin] = React.useState(1)
 
+  const {generateVotingKeys, isLoading} = useGenerateVotingKeys({
+    onSuccess: ({catalystKeyHex, votingKeyEncrypted}) => {
+      votingKeyEncryptedChanged(votingKeyEncrypted)
+      catalystKeyHexChanged(catalystKeyHex)
+
+      navigateTo.confirmTx()
+    },
+  })
+
   const [pin1Value, setPin1Value] = React.useState<null | string>(null)
   const [pin2Value, setPin2Value] = React.useState<null | string>(null)
   const [pin3Value, setPin3Value] = React.useState<null | string>(null)
@@ -140,7 +153,7 @@ export const ConfirmPin = () => {
   )
 
   const onNext = () => {
-    navigateTo.confirmTx()
+    generateVotingKeys(pin)
   }
 
   const handleOnPress = React.useCallback(
@@ -208,17 +221,57 @@ export const ConfirmPin = () => {
 
       <Padding>
         <Actions>
-          <Button shelleyTheme onPress={() => onNext()} title={strings.continueButton} disabled={!done} />
+          <Button shelleyTheme onPress={() => onNext()} title={strings.continueButton} disabled={!done || isLoading} />
         </Actions>
       </Padding>
 
       <Space height="lg" />
 
       <NumericKeyboard onKeyDown={onKeyDown} />
+
+      {isLoading && (
+        <View style={styles.loading}>
+          <ActivityIndicator size="large" color={isDark ? 'white' : 'black'} />
+        </View>
+      )}
     </SafeAreaView>
   )
 }
 
+type GenerateKeysInput = string
+
+interface GenerateKeysOutput {
+  catalystKeyHex: string
+  votingKeyEncrypted: string
+}
+
+type GenerateKeysError = Error
+
+const useGenerateVotingKeys = (
+  options?: UseMutationOptions<GenerateKeysOutput, GenerateKeysError, GenerateKeysInput>,
+) => {
+  const mutation = useMutation(async (pin: string) => {
+    const catalystKey = await generatePrivateKeyForCatalyst()
+      .then((key) => key.toRawKey())
+      .then((key) => key.asBytes())
+
+    const catalystKeyHex = Buffer.from(catalystKey).toString('hex')
+
+    const password = Buffer.from(pin.split('').map(Number))
+    const votingKeyEncrypted = await encryptWithPassword(password, catalystKey)
+
+    return {
+      catalystKeyHex,
+      votingKeyEncrypted,
+    }
+  }, options)
+
+  return {
+    ...mutation,
+    generateVotingKeys: mutation.mutate,
+  }
+}
+
 // NOTE: keyboard horizontal padding is 0, yet bottom must respect safe-area-view
 export const Padding = ({style, ...props}: ViewProps) => {
   const styles = useStyles()
@@ -235,6 +288,14 @@ const useStyles = () => {
     padding: {
       ...atoms.px_lg,
     },
+    loading: {
+      ...StyleSheet.absoluteFillObject,
+      backgroundColor: color.bg_color_max,
+      left: 0,
+      right: 0,
+      ...atoms.align_center,
+      ...atoms.justify_center,
+    },
   })
 
   return styles
diff --git a/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmVotingTx/ConfirmVotingTx.tsx b/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmVotingTx/ConfirmVotingTx.tsx
index bdd0fa3e98..4fca57c45c 100644
--- a/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmVotingTx/ConfirmVotingTx.tsx
+++ b/apps/wallet-mobile/src/features/RegisterCatalyst/useCases/ConfirmVotingTx/ConfirmVotingTx.tsx
@@ -23,7 +23,7 @@ export const ConfirmVotingTx = () => {
   const styles = useStyles()
   const strings = useStrings()
   const {openModal, closeModal} = useModal()
-  const {votingKeyEncryptedChanged, pin} = useCatalyst()
+  const {catalystKeyHex, pin} = useCatalyst()
   const navigateTo = useNavigateTo()
 
   const onNext = () => {
@@ -31,12 +31,10 @@ export const ConfirmVotingTx = () => {
   }
 
   if (pin === null) throw new Error('pin cannot be null')
+  if (catalystKeyHex === null) throw new Error('catalystKeyHex cannot be null')
 
   const {wallet, meta} = useSelectedWallet()
-  const votingRegTx = useVotingRegTx(
-    {wallet, pin, supportsCIP36, addressMode: meta.addressMode},
-    {onSuccess: ({votingKeyEncrypted}) => votingKeyEncryptedChanged(votingKeyEncrypted)},
-  )
+  const votingRegTx = useVotingRegTx({wallet, supportsCIP36, catalystKeyHex, addressMode: meta.addressMode})
 
   const [useUSB, setUseUSB] = useState(false)
 
diff --git a/apps/wallet-mobile/src/yoroi-wallets/cardano/cardano-wallet.ts b/apps/wallet-mobile/src/yoroi-wallets/cardano/cardano-wallet.ts
index 80ec60e5f5..085a085056 100644
--- a/apps/wallet-mobile/src/yoroi-wallets/cardano/cardano-wallet.ts
+++ b/apps/wallet-mobile/src/yoroi-wallets/cardano/cardano-wallet.ts
@@ -39,8 +39,6 @@ import {Cardano, CardanoMobile} from '../wallets'
 import {AccountManager, accountManagerMaker, Addresses} from './account-manager/account-manager'
 import * as legacyApi from './api/api'
 import {calcLockedDeposit} from './assetUtils'
-import {encryptWithPassword} from './catalyst/catalystCipher'
-import {generatePrivateKeyForCatalyst} from './catalyst/catalystUtils'
 import {createSwapCancellationLedgerPayload} from './common/signatureUtils'
 import {cardanoConfig} from './constants/cardano-config'
 import * as MAINNET from './constants/mainnet/constants'
@@ -436,23 +434,18 @@ export const makeCardanoWallet = (
     }
 
     async createVotingRegTx({
-      pin,
       supportsCIP36,
       addressMode,
+      catalystKeyHex,
     }: {
       pin: string
       supportsCIP36: boolean
       addressMode: Wallet.AddressMode
+      catalystKeyHex: string
     }) {
       if (implementationConfig.features.staking) {
-        const bytes = await generatePrivateKeyForCatalyst()
-          .then((key) => key.toRawKey())
-          .then((key) => key.asBytes())
-
         const primaryTokenId = this.primaryTokenInfo.id
 
-        const catalystKeyHex = Buffer.from(bytes).toString('hex')
-
         try {
           const time = await this.checkServerStatus()
             .then(({serverTime}) => serverTime || Date.now())
@@ -518,11 +511,7 @@ export const makeCardanoWallet = (
             nonce,
           }
 
-          const password = Buffer.from(pin.split('').map(Number))
-          const catalystKeyEncrypted = await encryptWithPassword(password, bytes)
-
           return {
-            votingKeyEncrypted: catalystKeyEncrypted,
             votingRegTx: await yoroiUnsignedTx({
               unsignedTx,
               networkConfig: NETWORK_CONFIG,
diff --git a/apps/wallet-mobile/src/yoroi-wallets/cardano/types.ts b/apps/wallet-mobile/src/yoroi-wallets/cardano/types.ts
index f8e61d3c75..afc3df8a34 100644
--- a/apps/wallet-mobile/src/yoroi-wallets/cardano/types.ts
+++ b/apps/wallet-mobile/src/yoroi-wallets/cardano/types.ts
@@ -120,10 +120,10 @@ export interface YoroiWallet {
 
   // Voting
   createVotingRegTx(params: {
-    pin: string
     supportsCIP36: boolean
     addressMode: Wallet.AddressMode
-  }): Promise<{votingRegTx: YoroiUnsignedTx; votingKeyEncrypted: string}>
+    catalystKeyHex: string
+  }): Promise<{votingRegTx: YoroiUnsignedTx}>
   fetchFundInfo(): Promise<FundInfoResponse>
 
   // Staking
diff --git a/apps/wallet-mobile/src/yoroi-wallets/hooks/index.ts b/apps/wallet-mobile/src/yoroi-wallets/hooks/index.ts
index d86a2d0555..92a6902a53 100644
--- a/apps/wallet-mobile/src/yoroi-wallets/hooks/index.ts
+++ b/apps/wallet-mobile/src/yoroi-wallets/hooks/index.ts
@@ -277,21 +277,20 @@ export const useWithdrawalTx = (
 
 export type VotingRegTxAndEncryptedKey = {
   votingRegTx: YoroiUnsignedTx
-  votingKeyEncrypted: string
 }
 
 export const useVotingRegTx = (
   {
     wallet,
-    pin,
+    catalystKeyHex,
     supportsCIP36,
     addressMode,
-  }: {wallet: YoroiWallet; pin: string; supportsCIP36: boolean; addressMode: Wallet.AddressMode},
+  }: {wallet: YoroiWallet; catalystKeyHex: string; supportsCIP36: boolean; addressMode: Wallet.AddressMode},
   options?: UseQueryOptions<
     VotingRegTxAndEncryptedKey,
     Error,
     VotingRegTxAndEncryptedKey,
-    [string, 'voting-reg-tx', string]
+    [string, string, 'voting-reg-tx', string]
   >,
 ) => {
   const query = useQuery({
@@ -299,8 +298,8 @@ export const useVotingRegTx = (
     retry: false,
     cacheTime: 0,
     suspense: true,
-    queryKey: [wallet.id, 'voting-reg-tx', JSON.stringify({supportsCIP36})],
-    queryFn: () => wallet.createVotingRegTx({pin, supportsCIP36, addressMode}),
+    queryKey: [catalystKeyHex, wallet.id, 'voting-reg-tx', JSON.stringify({supportsCIP36})],
+    queryFn: () => wallet.createVotingRegTx({catalystKeyHex, supportsCIP36, addressMode}),
   })
 
   if (!query.data) throw new Error('invalid state')
diff --git a/packages/staking/src/catalyst/translators/context.tsx b/packages/staking/src/catalyst/translators/context.tsx
index 65598d49fa..a1e4a910f3 100644
--- a/packages/staking/src/catalyst/translators/context.tsx
+++ b/packages/staking/src/catalyst/translators/context.tsx
@@ -53,6 +53,11 @@ export function CatalystProvider({
         type: CatalystActionType.VotingKeyEncryptedChanged,
         votingKeyEncrypted,
       }),
+    catalystKeyHexChanged: (catalystKeyHex: CatalystState['catalystKeyHex']) =>
+      dispatch({
+        type: CatalystActionType.CatalystKeyHexChanged,
+        catalystKeyHex,
+      }),
     reset: () =>
       dispatch({
         type: CatalystActionType.Reset,
diff --git a/packages/staking/src/catalyst/translators/state.test.tsx b/packages/staking/src/catalyst/translators/state.test.tsx
index c037db5e2b..00096625de 100644
--- a/packages/staking/src/catalyst/translators/state.test.tsx
+++ b/packages/staking/src/catalyst/translators/state.test.tsx
@@ -29,25 +29,45 @@ describe('State Actions', () => {
   })
 
   it('VotingKeyEncryptedChanged', () => {
+    const votingKeyEncrypted = 'super-complex-voting-key'
     const action: CatalystAction = {
       type: CatalystActionType.VotingKeyEncryptedChanged,
-      votingKeyEncrypted: 'very-strong-key',
+      votingKeyEncrypted,
     }
 
     const state = catalystReducer(catalystDefaultState, action)
-    expect(state.votingKeyEncrypted).toBe('very-strong-key')
+    expect(state.votingKeyEncrypted).toBe(votingKeyEncrypted)
+  })
+
+  it('CatalystKeyHexChanged', () => {
+    const catalystKeyHex = 'super-complex-hex'
+    const action: CatalystAction = {
+      type: CatalystActionType.CatalystKeyHexChanged,
+      catalystKeyHex,
+    }
+
+    const state = catalystReducer(catalystDefaultState, action)
+    expect(state.catalystKeyHex).toBe(catalystKeyHex)
   })
 
   it('Reset', () => {
+    const votingKeyEncrypted = 'super-complex-voting-key'
+    const catalystKeyHex = 'super-complex-catalyst-key'
     const action: CatalystAction = {
       type: CatalystActionType.Reset,
     }
 
     const state = catalystReducer(
-      {...catalystDefaultState, pin: '1234', votingKeyEncrypted: 'qwert'},
+      {
+        ...catalystDefaultState,
+        pin: '1234',
+        votingKeyEncrypted,
+        catalystKeyHex,
+      },
       action,
     )
     expect(state.pin).toBe(null)
     expect(state.votingKeyEncrypted).toBe(null)
+    expect(state.catalystKeyHex).toBe(null)
   })
 })
diff --git a/packages/staking/src/catalyst/translators/state.tsx b/packages/staking/src/catalyst/translators/state.tsx
index c525923962..08e2f60517 100644
--- a/packages/staking/src/catalyst/translators/state.tsx
+++ b/packages/staking/src/catalyst/translators/state.tsx
@@ -14,9 +14,14 @@ export const catalystReducer = (
         draft.votingKeyEncrypted = action.votingKeyEncrypted
         break
 
+      case CatalystActionType.CatalystKeyHexChanged:
+        draft.catalystKeyHex = action.catalystKeyHex
+        break
+
       case CatalystActionType.Reset:
         draft.pin = catalystDefaultState.pin
         draft.votingKeyEncrypted = catalystDefaultState.votingKeyEncrypted
+        draft.catalystKeyHex = catalystDefaultState.catalystKeyHex
         break
 
       default:
@@ -29,6 +34,7 @@ export const catalystDefaultState: Readonly<CatalystState> = freeze(
   {
     pin: null,
     votingKeyEncrypted: null,
+    catalystKeyHex: null,
   },
   true,
 )
@@ -36,6 +42,7 @@ export const catalystDefaultState: Readonly<CatalystState> = freeze(
 export type CatalystState = {
   pin: string | null
   votingKeyEncrypted: string | null
+  catalystKeyHex: string | null
 }
 
 export type CatalystAction =
@@ -44,6 +51,10 @@ export type CatalystAction =
       type: CatalystActionType.VotingKeyEncryptedChanged
       votingKeyEncrypted: CatalystState['votingKeyEncrypted']
     }
+  | {
+      type: CatalystActionType.CatalystKeyHexChanged
+      catalystKeyHex: CatalystState['catalystKeyHex']
+    }
   | {
       type: CatalystActionType.Reset
     }
@@ -51,6 +62,7 @@ export type CatalystAction =
 export enum CatalystActionType {
   PinChanged = 'pinChanged',
   VotingKeyEncryptedChanged = 'votingKeyEncryptedChanged',
+  CatalystKeyHexChanged = 'catalystKeyHexChanged',
   Reset = 'reset',
 }
 
@@ -59,6 +71,9 @@ export type CatalystActions = {
   votingKeyEncryptedChanged: (
     votingKeyEncrypted: CatalystState['votingKeyEncrypted'],
   ) => void
+  catalystKeyHexChanged: (
+    catalystKeyHex: CatalystState['catalystKeyHex'],
+  ) => void
   reset: () => void
 }
 
@@ -67,6 +82,7 @@ export const initialCatalystContext: CatalystState & CatalystActions = freeze(
     ...catalystDefaultState,
     pinChanged: missingInit,
     votingKeyEncryptedChanged: missingInit,
+    catalystKeyHexChanged: missingInit,
     reset: missingInit,
   },
   true,