Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-mobile): receive address copied feedback in tx history actions banner #3758

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(wallet-mobile): receive address copied feedback in tx history actions banner #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ada369
fix(wallet-mobile): tx history actions banner receive address copied …
banklesss Dec 10, 2024
d95da5b
Merge branch 'develop' into fix/tx-history-receive-action-button-copy
banklesss Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/wallet-mobile/src/features/Transactions/common/strings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export const useStrings = () => {
SELF: intl.formatMessage(txTypeMessages.SELF),
MULTI: intl.formatMessage(txTypeMessages.MULTI),
assetsLabel: intl.formatMessage(globalMessages.assetsLabel),
copiedLabel: intl.formatMessage(messages.copiedLabel),
}
}

Expand Down Expand Up @@ -179,6 +180,10 @@ export const messages = defineMessages({
id: 'components.receive.addressmodal.copyLabel',
defaultMessage: '!!!Copy address',
},
copiedLabel: {
id: 'components.receive.addressmodal.copiedLabel',
defaultMessage: '!!!Address Copied',
},
spending: {
id: 'components.receive.addressmodal.spendingKeyHash',
defaultMessage: '!!!Spending',
Expand Down
2 changes: 1 addition & 1 deletion apps/wallet-mobile/src/features/Transactions/useCases/TxHistory/ActionsBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const ActionsBanner = ({disabled = false}: {disabled: boolean}) => {

const handleOnLongPressReceive = (event: GestureResponderEvent) => {
track.receiveCopyAddressClicked({copy_address_location: 'Long Press wallet Address'})
copy({text: nextReceiveAddress, event})
copy({text: nextReceiveAddress, event, feedback: strings.copiedLabel})
}

return (
Expand Down
2 changes: 1 addition & 1 deletion apps/wallet-mobile/src/kernel/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@
"components.pooltransition.updateKeepEarning": "Update now and keep earning",
"components.pooltransition.update": "Update pool",
"components.receive.addressmodal.BIP32path": "Derivation path",
"components.receive.addressmodal.copiedLabel": "Copied",
"components.receive.addressmodal.copiedLabel": "Address Copied",
"components.receive.addressmodal.copyLabel": "Copy address",
"components.receive.addressmodal.spendingKeyHash": "Spending key hash",
"components.receive.addressmodal.stakingKeyHash": "Staking key hash",
Expand Down
Loading
Loading