Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Laravel Pint as a linter #100

Closed
dmohns opened this issue Jun 17, 2024 · 4 comments
Closed

Explore Laravel Pint as a linter #100

dmohns opened this issue Jun 17, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dmohns
Copy link
Member

dmohns commented Jun 17, 2024

Being a Laravel project maybe it would be great to also adhere to the "official" Laravel Code Style: https://laravel.com/docs/11.x/pint

@dmohns dmohns added enhancement New feature or request good first issue Good for newcomers labels Jun 17, 2024
@pechtelt1
Copy link

@dmohns i think this is a good idea. Do you have some code style requirements or do you just want to have the default Laravel Pint?

@munyanezaarmel
Copy link
Contributor

@dmohns If this issue is still relevant, I would be happy to take it on.

@dmohns
Copy link
Member Author

dmohns commented Nov 19, 2024

Sure, it's still somewhat relevant. Feel free to take a look 👍

Bear in mind that we recently adopted PHP-CS-Fixer, see #99 So we'd have to check how the two interact.

@dmohns
Copy link
Member Author

dmohns commented Nov 26, 2024

We are not going to use Laravel Pint as we already have PHP-CS-Fixer. For more details, see response here: #364 (comment)

@dmohns dmohns closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants