Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Laravel Health route is broken #290

Open
3 tasks done
dmohns opened this issue Sep 25, 2024 · 0 comments · May be fixed by #424
Open
3 tasks done

[Bug]: Laravel Health route is broken #290

dmohns opened this issue Sep 25, 2024 · 0 comments · May be fixed by #424
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Issues for the Hacktoberfest 2024 https://hacktoberfest.com/ help wanted Extra attention is needed

Comments

@dmohns
Copy link
Member

dmohns commented Sep 25, 2024

Preflight Checklist

Expected Behavior

curl localhost:8000/up

returns 200,

This is helpful in Kubernetes deployment scenarios.

Additionally, once this works, please add a HEALTHCHECK to our Dockerfile, see https://docs.docker.com/reference/dockerfile/#healthcheck

Actual Behavior

curl localhost:8000/up

returns 500. Because of the compnayId logic in routes.

Steps to reproduce

See above

What operating system(s) are you using?

macOS

Additional Information

See details: https://laravel.com/docs/11.x/deployment#the-health-route

@dmohns dmohns added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Issues for the Hacktoberfest 2024 https://hacktoberfest.com/ labels Sep 25, 2024
beesaferoot added a commit that referenced this issue Dec 13, 2024
This change expose an /up route that is meant to be used
for health checks i.e docker compose health, and in kubernetes environment.
@beesaferoot beesaferoot linked a pull request Dec 13, 2024 that will close this issue
4 tasks
beesaferoot added a commit that referenced this issue Dec 13, 2024
@beesaferoot beesaferoot self-assigned this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Issues for the Hacktoberfest 2024 https://hacktoberfest.com/ help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants