From 92cfbe6c97fe305c1c9cfb25761be208e26a1233 Mon Sep 17 00:00:00 2001
From: Mario Ramos <mariodarken@gmail.com>
Date: Mon, 18 Mar 2024 20:22:19 +0100
Subject: [PATCH 1/2] Modify `StrictFormatCleanPdfDocumentConnector` access
 modifiers to facilitate the inheritance

---
 Directory.Build.props                             |  2 +-
 .../Controllers/BotBaseController.cs              |  3 +++
 .../StrictFormatCleanPdfDocumentConnector.cs      | 15 +++++++++++++--
 3 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 11e4030..7fdc2ff 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -17,7 +17,7 @@
 
   <PropertyGroup>
     <VersionPrefix>8.1.5</VersionPrefix>
-    <VersionSuffix>preview-13</VersionSuffix>
+    <VersionSuffix>preview-14</VersionSuffix>
   </PropertyGroup>
 
   <!--
diff --git a/src/Encamina.Enmarcha.Bot/Controllers/BotBaseController.cs b/src/Encamina.Enmarcha.Bot/Controllers/BotBaseController.cs
index 822735e..a64c778 100644
--- a/src/Encamina.Enmarcha.Bot/Controllers/BotBaseController.cs
+++ b/src/Encamina.Enmarcha.Bot/Controllers/BotBaseController.cs
@@ -36,6 +36,9 @@ protected BotBaseController(IBotFrameworkHttpAdapter adapter, IBot bot)
     /// <summary>
     /// Handles a request for the bot.
     /// </summary>
+    /// <remarks>
+    /// This method does not uses a `CancellationToken` because Azure Bot Service would cancel the request if it did not receive a response within 15 seconds.
+    /// </remarks>
     /// <returns>
     /// A <see cref="Task"/> that represents the asynchronous operation of handling the request for the bot.
     /// </returns>
diff --git a/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/Connectors/StrictFormatCleanPdfDocumentConnector.cs b/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/Connectors/StrictFormatCleanPdfDocumentConnector.cs
index 6b1b10e..8485b0d 100644
--- a/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/Connectors/StrictFormatCleanPdfDocumentConnector.cs
+++ b/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/Connectors/StrictFormatCleanPdfDocumentConnector.cs
@@ -51,7 +51,12 @@ public override string ReadText(Stream stream)
         return sb.ToString();
     }
 
-    private static IEnumerable<TextBlock> GetTextBlocks(Page page)
+    /// <summary>
+    /// Extracts <see cref="TextBlock"/> from a given page of a PDF document.
+    /// </summary>
+    /// <param name="page">The page from which to extract text blocks.</param>
+    /// <returns>An enumerable collection of <see cref="TextBlock" /> extracted from the page.</returns>
+    protected static IEnumerable<TextBlock> GetTextBlocks(Page page)
     {
         // 1. Extract words
         var words = NearestNeighbourWordExtractor.Instance.GetWords(page.Letters);
@@ -70,7 +75,13 @@ private static IEnumerable<TextBlock> GetTextBlocks(Page page)
         return orderedTextBlocks;
     }
 
-    private static IEnumerable<TextBlock> CleanTextBlocks(PdfDocument document, IEnumerable<TextBlock> textBlocks)
+    /// <summary>
+    /// Cleans the extracted text blocks from a PDF document by removing common words that overlap across pages and excluding non-horizontal text.
+    /// </summary>
+    /// <param name="document">The PDF document.</param>
+    /// <param name="textBlocks">The extracted text blocks.</param>
+    /// <returns>The cleaned text blocks.</returns>
+    protected static IEnumerable<TextBlock> CleanTextBlocks(PdfDocument document, IEnumerable<TextBlock> textBlocks)
     {
         var horizontalTextBlocks = textBlocks
             .Where(tb => tb.TextOrientation == TextOrientation.Horizontal)

From 95f45896de2dbd71444bc8511fc29cbaecee5c10 Mon Sep 17 00:00:00 2001
From: Mario Ramos <mariodarken@gmail.com>
Date: Mon, 18 Mar 2024 20:22:56 +0100
Subject: [PATCH 2/2] Make `IDocumentConnectorUtils` public to allow use the
 utils outside the library

---
 .../IDocumentConnectorUtils.cs                                | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/IDocumentConnectorUtils.cs b/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/IDocumentConnectorUtils.cs
index f35eba4..c850e21 100644
--- a/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/IDocumentConnectorUtils.cs
+++ b/src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/IDocumentConnectorUtils.cs
@@ -12,7 +12,7 @@ namespace Encamina.Enmarcha.SemanticKernel.Connectors.Document;
 /// <summary>
 /// Utility class providing methods for working with document connectors.
 /// </summary>
-internal static class IDocumentConnectorUtils
+public static class IDocumentConnectorUtils
 {
     /// <summary>
     /// Gets the default document connector based on the specified file extension.
@@ -20,7 +20,7 @@ internal static class IDocumentConnectorUtils
     /// <param name="fileExtension">The file extension for which to retrieve the connector.</param>
     /// <returns>An instance of the default document connector for the specified file extension.</returns>
     /// <exception cref="NotSupportedException">Thrown when the file extension is not supported.</exception>
-    internal static IDocumentConnector GetDefaultDocumentConnector(string fileExtension)
+    public static IDocumentConnector GetDefaultDocumentConnector(string fileExtension)
     {
         return fileExtension.ToUpperInvariant() switch
         {