Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EMB-independent EMI #23

Merged
merged 13 commits into from
Aug 20, 2024
Merged

Support EMB-independent EMI #23

merged 13 commits into from
Aug 20, 2024

Conversation

hellemo
Copy link
Member

@hellemo hellemo commented Jun 19, 2024

Move Geo extension from EMI to EMG as part of making EMI independent of EMB.

All tests pass locally for this branch together with:
EnergyModelsX/EnergyModelsInvestments.jl#28 and EnergyModelsX/EnergyModelsBase.jl#34

@hellemo hellemo added the enhancement New feature or request label Jun 19, 2024
@hellemo hellemo self-assigned this Jun 19, 2024
@hellemo hellemo marked this pull request as draft June 19, 2024 13:49
@hellemo hellemo requested a review from JulStraus June 19, 2024 13:49
@JulStraus
Copy link
Member

Force push due to #24 and corresponding rebase.

@JulStraus JulStraus marked this pull request as ready for review August 20, 2024 09:10
Copy link
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seams reasonable to me.
In general, it looks to me as if there are only minor changes in the individual files, except for the documentation.

@JulStraus JulStraus merged commit e34f545 into main Aug 20, 2024
5 checks passed
@JulStraus JulStraus deleted the lh/emi_indep branch August 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants