Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light shaders aren't properly copied when copying SimpleMaterial builders #266

Closed
MattiDragon opened this issue Oct 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@MattiDragon
Copy link

Describe the Bug

The light field, holding shaders for lighting, is not correctly copied when copying a material builder. This causes the light shaders to be null, causing crashes later down the line.

The light shader should be copied between these lines, but it isn't.

Reproduction Steps

  1. Look at the code for copying materials.
  2. Notice that the light isn't ever copied and remains null

Expected Result

The light field would be copied or assigned some reasonable default

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11 Home

What is your GPU?

RTX 3070

Mod Version

0.6.8.a

Minecraft Version

1.19.2

Loader Version

Fabric 0.16.7 (mc 1.21.1)

Other Mods

Note: I have only reproduced on the 1.21 pr fork, but the same code exist on other branches as well. I've set the mod and minecraft versions to the latest values as I cannot represent them correctly

Additional Context

No response

@MattiDragon MattiDragon added the bug Something isn't working label Oct 13, 2024
@PepperCode1
Copy link
Member

The fix for this is already in #262, but can be merged separately if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants