Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apothic Enchanting #166

Closed
purrloftruth opened this issue Oct 10, 2024 · 8 comments
Closed

Apothic Enchanting #166

purrloftruth opened this issue Oct 10, 2024 · 8 comments
Labels
fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released Suggestion

Comments

@purrloftruth
Copy link

URL

https://www.curseforge.com/minecraft/mc-mods/apothic-enchanting

Why would you like the mod added?

From Curseforge:

Apothic Enchanting is the Enchanting Module of Apotheosis. It provides a full overhaul to Minecraft's enchanting system, as well as new enchantments and utilities to further improve the experience.

It seems Apotheosis is being broken into multiple mods for 1.21. (One of them, Apothic Spawners, is already in E10.)

@NielsPilgaard
Copy link
Collaborator

I'd rather we go with vanilla-style enchanting this time around, to try something different 😄

@NielsPilgaard NielsPilgaard closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
@theboo
Copy link

theboo commented Dec 30, 2024

Curious if we can revisit this request? My personal favorite parts of this mod arent even the enchanting table changes(tho i do think these make the otherwise insufferable enchanting table a bit more bearable), i would still be mostly using other mods to get the specific enchants i want.

The higher level enchantments+very easy config for us to control what level you can combine any given enchant to with anvil combining is very nice. But what im missing from it most are the enchantment library(very nice, convenient single block enchantment storage) and the various fairly unique enchants it adds(like crescendo of bolts, life mending and knowledge of the ages to name a few).

@NielsPilgaard
Copy link
Collaborator

I can live with adding this, but I'd personally prefer to play without. I'm quite fond of the vanilla enchanting system, simple as it may be :D

@theboo
Copy link

theboo commented Dec 30, 2024

i'll ping @MuteTiefling here, and if they agree with you i'll graciously concede defeat... but if they agree with me, maybe we add?

@MuteTiefling
Copy link
Contributor

I wouldn't mind taking a look to see if we can get just what we want and nothing else.

Keeping vanilla enchant levels is easy.

I know the enchanting library is oft requested and would be nice.

And boo is mostly just looking for a couple enchants added by this.

So if it's not too much effort to keep the vanilla enchanting system and ditch all the extra shelves, I'm ok with it.

@DoomSquirter
Copy link

I vote for the whole shebang. I know this doesn't matter as much but I guarantee you, ppl are going to be very annoyed to have apoth enchanting but have it nerfed to hell.

Also, just to re-emphasize. this is a kitchen sink pack and there are no plans to turn it into a expert pack. I don't see the nuance here in trying to hobble a mod like this.

@MuteTiefling
Copy link
Contributor

Doesn't seem feasible anyway. There's no config that I'm seeing for disabling the apotheosis enchanting table, so it'd be all or nothing.

Oh and the Occultism Iesnium Anvil doesn't appear to respect the apotheosis max level configs either. It simply allows any enchant to go to X if the enchanting module is installed....

@MuteTiefling
Copy link
Contributor

It does fix the enchant names beyond X though... which Oritech lets you go beyond anyway. So yeah, I think at this point the only reason not to install it is to maintain a simpler enchanting table interface.

@NielsPilgaard NielsPilgaard reopened this Dec 31, 2024
@NielsPilgaard NielsPilgaard added the fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released label Dec 31, 2024
NielsPilgaard added a commit that referenced this issue Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released Suggestion
Projects
None yet
Development

No branches or pull requests

5 participants