Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw error on empty SCSS files #2

Open
DanielGibbsNZ opened this issue Jul 16, 2017 · 2 comments
Open

Don't throw error on empty SCSS files #2

DanielGibbsNZ opened this issue Jul 16, 2017 · 2 comments
Labels

Comments

@DanielGibbsNZ
Copy link
Contributor

I'm using this plugin to dynamically extract SCSS files and sometimes one of the files I need to extract variables from doesn't have any variables in it (or is totally empty). This causes the error Error while extracting declaration to be thrown.

Would it be possible to somehow allow it to continue even if there are no variables in one of the files?

@EnoahNetzach
Copy link
Owner

Would be possible for you to add at least an e2e test that fails in this case in a PR?

@DanielGibbsNZ
Copy link
Contributor Author

See #3. I've fixed the issue and also added an empty stylesheet to the e2e tests which causes the tests to fail without my fix. I'm not sure if you want to fix it this way but at least will give you an idea of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants