This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
PlatformProxyAdmin
deployer
constant concerns
#229
Labels
The code4rena issue https://github.com/code-423n4/2022-05-enso-findings/issues/217 raises that the
deployer
constant is "useless" since the inheritedProxyAdmin
is ownable, thus theinitialize
function could be modified to be callable only by the owner.If the intended design of
deployer
was to accommodate thePlatformProxyAdmin
itself to be proxied, than theowner
credentials would be lost, bricking theProxyAdmin
onlyOwner
controlled functions. So as it is set up, thePlatformProxyAdmin
should NOT be proxied.So far during the code4rena engagement there have been no other changes to the
PlatformProxyAdmin
so it would not need to be redeployed. This means it would not make sense to remove this "useless" constant.label "tracking" used since there is no actionable item on this issue other than consideration and possibly revisiting in the future.
The text was updated successfully, but these errors were encountered: