You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I checked my configurations files and the documentation
Command used
Upload all notes
Plugin version
6.4.0
Describe the bug
The Regex on filename / folder path has two issues for me:
Escaping special characters.
In regex () characters or [] have their special meaning. To match them in text we need to escape them with \. But adding the backslash to regex, throws an error Folder path cannot contain the character `.
The tool does not check for trailing slash / after the folder path string has been cleaned up.
So, if I want to remove hentai_stash from source/hentai_stash/hatsune_miku.mp3 I have to match for /hentai_stash, while hentai_stash should be sufficient. But even worse! While hentai_stash is going to throw an error. hentai_stash/ is not going to match at all and fail silently!
The tool does not check for trailing slash / after the folder path string has been cleaned up.
So, if I want to remove hentai_stash from source/hentai_stash/hatsune_miku.mp3 I have to match for /hentai_stash, while hentai_stash should be sufficient. But even worse! While hentai_stash is going to throw an error. hentai_stash/ is not going to match at all and fail silently!
If I'm correct, the tool must use source/hentai_stash/hatsune_miku.mp3 → source//hatsune_miku.mp3 in the "actual state" of the plugin regex, no ?
EDIT: Yeah, it's is that.
Okay will fix it asap, thanks
As I do a big refactor, the update is behind them. If you want to try it, you can install it with BRAT using https://github.com/ObsidianPublisher/obsidian-github-publisher
Issue validation
Command used
Upload all notes
Plugin version
6.4.0
Describe the bug
The Regex on filename / folder path has two issues for me:
In regex
()
characters or[]
have their special meaning. To match them in text we need to escape them with\
. But adding the backslash to regex, throws an errorFolder path cannot contain the character
`./
after the folder path string has been cleaned up.So, if I want to remove
hentai_stash
fromsource/hentai_stash/hatsune_miku.mp3
I have to match for/hentai_stash
, whilehentai_stash
should be sufficient. But even worse! Whilehentai_stash
is going to throw an error.hentai_stash/
is not going to match at all and fail silently!Maybe related to #115
How to reproduce ?
No response
Minimal Reproducible Example
Configuration
No need
Relevant log output
This comes up when folder name is used without preceding
/
OS
Windows
Anything else?
No response
Obsidian information
SYSTEM INFO: Obsidian version: v1.3.7 Installer version: v1.3.7 Operating system: Windows 10 Login status: not logged in Insider build toggle: off Live preview: on Legacy editor: off Base theme: dark Community theme: none Snippets enabled: 0 Restricted mode: off Plugins installed: 6 Plugins enabled: 5 1: Simple Embeds v1.14.1 2: Tasks Calendar Wrapper v0.2.5 3: Tasks v4.6.0 4: ReadItLater v0.3.1 5: Github Publisher v6.4.0
The text was updated successfully, but these errors were encountered: