Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin][Bug]: share "false" also publishes note #225

Closed
2 tasks done
anutator opened this issue Sep 25, 2023 · 2 comments
Closed
2 tasks done

[Plugin][Bug]: share "false" also publishes note #225

anutator opened this issue Sep 25, 2023 · 2 comments
Assignees
Labels
🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin

Comments

@anutator
Copy link

anutator commented Sep 25, 2023

Issue validation

  • I checked the issue to prevent duplicate
  • I checked my configurations files and the documentation

Command used

Refresh published and upload new notes

Plugin version

6.5.8

Describe the bug

When I add tag share: false my note is also published. It is not published If I don't have this tag at all. I'd like to publish only with share: true or share: yes.
2023-09-25_202442

How to reproduce ?

Add tag share: false.

Minimal Reproducible Example

On screenshot

Configuration

Config - https://github.com/anutator/blog/blob/main/mkdocs.yml

Relevant log output

No response

OS

No response

Anything else?

No response

Obsidian information

1.4.13 version
@anutator anutator added 🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin labels Sep 25, 2023
@Mara-Li
Copy link
Member

Mara-Li commented Sep 25, 2023

Okay, i know the problem.

It's around property or the way property is scanned by Obsidian. You are using a string value, not a boolean. By default, my plugin check only for boolean value!

@anutator
Copy link
Author

I've upated the plugin. Now it checks false value. Thank you..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin
Projects
None yet
Development

No branches or pull requests

2 participants